CR-9648 uninstall runtime on different kube context bug (#456)

* get current context name explicitly

* ensuring runtime is on chosen kube context

* logs

* bump version

* small change

Author: rotem-codefresh

Makefile

@@ -1,4 +1,4 @@
-VERSION=v0.0.403
+VERSION=v0.0.404
 
 OUT_DIR=dist
 YEAR?=$(shell date +"%Y")

cmd/commands/common.go

@@ -425,6 +425,11 @@ func getKubeContextName(context, kubeconfig *pflag.Flag) (string, error) {
 		}
 	}
 
+	if contextName == "" {
+		contextName = util.KubeCurrentContextName(kubeconfigPath)
+		log.G().Infof("Using current kube context '%s'", contextName)
+	}
+
 	return contextName, context.Value.Set(contextName)
 }
 
@@ -657,3 +662,23 @@ func isRuntimeManaged(ctx context.Context, runtimeName string) (bool, error) {
 
 	return rt.Managed, nil
 }
+
+func ensureRuntimeOnKubeContext(ctx context.Context, kubeconfig string, runtimeName string, kubeContextName string) error {
+	rt, err := cfConfig.NewClient().V2().Runtime().Get(ctx, runtimeName)
+	if err != nil {
+		return fmt.Errorf("failed to get runtime from platform. error: %w", err)
+	}
+
+	runtimeClusterServer := rt.Cluster
+
+	kubeContextServer, err := util.KubeServerByContextName(kubeContextName, kubeconfig)
+	if err != nil {
+		return err
+	}
+
+	if *runtimeClusterServer != kubeContextServer {
+		return fmt.Errorf("runtime '%s' does not exist on context '%s'. make sure you are providing the right kube context", runtimeName, kubeContextName)
+	}
+
+	return nil
+}

cmd/commands/runtime.go

@@ -455,6 +455,15 @@ func runtimeUninstallCommandPreRunHandler(cmd *cobra.Command, args []string, opt
 		return err
 	}
 
+	if !opts.Managed {
+		kubeconfig := cmd.Flag("kubeconfig").Value.String()
+		err = ensureRuntimeOnKubeContext(cmd.Context(), kubeconfig, opts.RuntimeName, opts.kubeContext)
+	}
+	handleCliStep(reporter.UninstallStepPreCheckEnsureRuntimeOnKubeContext, "Ensuring runtime is on the kube context", err, true, false)
+	if err != nil {
+		return err
+	}
+
 	if !opts.Managed {
 		err = ensureRepo(cmd, opts.RuntimeName, opts.CloneOpts, true)
 	}
@@ -1637,12 +1646,13 @@ func RunRuntimeUninstall(ctx context.Context, opts *RuntimeUninstallOptions) err
 
 	if !opts.Managed {
 		err = apcmd.RunRepoUninstall(ctx, &apcmd.RepoUninstallOptions{
-			Namespace:    opts.RuntimeName,
-			Timeout:      opts.Timeout,
-			CloneOptions: opts.CloneOpts,
-			KubeFactory:  opts.KubeFactory,
-			Force:        opts.Force,
-			FastExit:     opts.FastExit,
+			Namespace:       opts.RuntimeName,
+			KubeContextName: opts.kubeContext,
+			Timeout:         opts.Timeout,
+			CloneOptions:    opts.CloneOpts,
+			KubeFactory:     opts.KubeFactory,
+			Force:           opts.Force,
+			FastExit:        opts.FastExit,
 		})
 	}
 	cancel() // to tell the progress to stop displaying even if it's not finished

docs/releases/release_notes.md

@@ -23,7 +23,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.403/cf-linux-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.404/cf-linux-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-linux-amd64 /usr/local/bin/cf
@@ -36,7 +36,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.403/cf-darwin-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.404/cf-darwin-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-darwin-amd64 /usr/local/bin/cf

manifests/runtime.yaml

@@ -5,7 +5,7 @@ metadata:
   namespace: "{{ namespace }}"
 spec:
   defVersion: 1.0.1
-  version: 0.0.403
+  version: 0.0.404
   bootstrapSpecifier: github.com/codefresh-io/cli-v2/manifests/argo-cd
   components:
     - name: events

pkg/reporter/reporter.go

@@ -96,21 +96,22 @@ const (
 	InstallPhaseFinish                                CliStep = "install.run.phase.finish"
 
 	// Uninstall
-	UninstallPhasePreCheckStart                   CliStep = "uninstall.pre-check.phase.start"
-	UninstallStepPreCheckGetKubeContext           CliStep = "uninstall.pre-check.step.get-kube-context"
-	UninstallStepPreCheckEnsureRuntimeName        CliStep = "uninstall.pre-check.step.ensure-runtime-name"
-	UninstallStepPreCheckRuntimeNameValidation    CliStep = "uninstall.pre-check.step.runtime-name-validation"
-	UninstallStepPreCheckEnsureRuntimeRepo        CliStep = "uninstall.pre-check.step.ensure-runtime-repo"
-	UninstallStepPreCheckEnsureGitToken           CliStep = "uninstall.pre-check.step.ensure-git-token"
-	UninstallPhasePreCheckFinish                  CliStep = "uninstall.pre-check.phase.finish"
-	UninstallPhaseStart                           CliStep = "uninstall.run.phase.start"
-	UninstallStepCheckRuntimeExists               CliStep = "uninstall.run.step.check-runtime-exists"
-	UninstallStepUninstallRepo                    CliStep = "uninstall.run.step.uninstall-repo"
-	UninstallStepRemoveGitIntegrations            CliStep = "uninstall.run.step.remove-git-integrations"
-	UninstallStepRemoveRuntimeIsc                 CliStep = "uninstall.run.step.remove-runtime-isc"
-	UninstallStepDeleteRuntimeFromPlatform        CliStep = "uninstall.run.step.delete-runtime-from-platform"
-	UninstallStepDeleteManagedRuntimeFromPlatform CliStep = "uninstall.run.step.delete-managed-runtime-from-platform"
-	UninstallPhaseFinish                          CliStep = "uninstall.run.phase.finish"
+	UninstallPhasePreCheckStart                     CliStep = "uninstall.pre-check.phase.start"
+	UninstallStepPreCheckGetKubeContext             CliStep = "uninstall.pre-check.step.get-kube-context"
+	UninstallStepPreCheckEnsureRuntimeOnKubeContext CliStep = "uninstall.pre-check.step.ensure-runtime-on-kube-context"
+	UninstallStepPreCheckEnsureRuntimeName          CliStep = "uninstall.pre-check.step.ensure-runtime-name"
+	UninstallStepPreCheckRuntimeNameValidation      CliStep = "uninstall.pre-check.step.runtime-name-validation"
+	UninstallStepPreCheckEnsureRuntimeRepo          CliStep = "uninstall.pre-check.step.ensure-runtime-repo"
+	UninstallStepPreCheckEnsureGitToken             CliStep = "uninstall.pre-check.step.ensure-git-token"
+	UninstallPhasePreCheckFinish                    CliStep = "uninstall.pre-check.phase.finish"
+	UninstallPhaseStart                             CliStep = "uninstall.run.phase.start"
+	UninstallStepCheckRuntimeExists                 CliStep = "uninstall.run.step.check-runtime-exists"
+	UninstallStepUninstallRepo                      CliStep = "uninstall.run.step.uninstall-repo"
+	UninstallStepRemoveGitIntegrations              CliStep = "uninstall.run.step.remove-git-integrations"
+	UninstallStepRemoveRuntimeIsc                   CliStep = "uninstall.run.step.remove-runtime-isc"
+	UninstallStepDeleteRuntimeFromPlatform          CliStep = "uninstall.run.step.delete-runtime-from-platform"
+	UninstallStepDeleteManagedRuntimeFromPlatform   CliStep = "uninstall.run.step.delete-managed-runtime-from-platform"
+	UninstallPhaseFinish                            CliStep = "uninstall.run.phase.finish"
 
 	// Upgrade
 	UpgradePhasePreCheckStart              CliStep = "upgrade.pre-check.phase.start"

pkg/util/util.go

@@ -225,6 +225,11 @@ func KubeCurrentServer(kubeconfig string) (string, error) {
 	return KubeServerByContextName("", kubeconfig)
 }
 
+func KubeCurrentContextName(kubeconfig string) string {
+	conf := kubeConfig(kubeconfig)
+	return conf.CurrentContext
+}
+
 func CurrentAccount(user *codefresh.User) (string, error) {
 	for i := range user.Accounts {
 		if user.Accounts[i].Name == user.ActiveAccountName {