Cr 14272 (#615)

* add a post uninstall step that deletes leftover secrets

* bump

* only fail post uninstall cleanup if no force

* bump

Author: danielm-codefresh

Makefile

@@ -1,4 +1,4 @@
-VERSION=v0.0.556
+VERSION=v0.0.557
 
 OUT_DIR=dist
 YEAR?=$(shell date +"%Y")

cmd/commands/runtime.go

@@ -579,7 +579,11 @@ func runRuntimeUninstall(ctx context.Context, opts *RuntimeUninstallOptions) err
 
 	err = runPostUninstallCleanup(ctx, opts.KubeFactory, opts.RuntimeName)
 	if err != nil {
-		return fmt.Errorf("failed to do post uninstall cleanup: %w", err)
+		errorMsg := fmt.Sprintf("failed to do post uninstall cleanup: %v", err)
+		if !opts.Force {
+			return fmt.Errorf(errorMsg)
+		}
+		log.G().Warn(errorMsg)
 	}
 
 	uninstallDoneStr := fmt.Sprintf("Done uninstalling runtime \"%s\"", opts.RuntimeName)
@@ -597,7 +601,7 @@ func runPostUninstallCleanup(ctx context.Context, kubeFactory kube.Factory, name
 	for _, secret := range secrets.Items {
 		err = kubeutil.DeleteSecretWithFinalizer(ctx, kubeFactory, &secret)
 		if err != nil {
-			log.G().Warn("failed to delete secret: %w", err)
+			log.G().Warnf("failed to delete secret: %w", err)
 		}
 	}
 

docs/releases/release_notes.md

@@ -23,7 +23,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.556/cf-linux-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.557/cf-linux-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-linux-amd64 /usr/local/bin/cf
@@ -36,7 +36,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.556/cf-darwin-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.557/cf-darwin-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-darwin-amd64 /usr/local/bin/cf

manifests/runtime.yaml

@@ -5,7 +5,7 @@ metadata:
   namespace: "{{ namespace }}"
 spec:
   defVersion: 2.1.1
-  version: 0.0.556
+  version: 0.0.557
   bootstrapSpecifier: github.com/codefresh-io/cli-v2/manifests/argo-cd
   components:
     - name: events