Skip to content

⚡️ Speed up method UpstashVectorConfig.check_credentials_or_client by 19% #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method UpstashVectorConfig.check_credentials_or_client by 19% #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions mem0/configs/vector_stores/upstash_vector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,17 @@ class UpstashVectorConfig(BaseModel):
@classmethod
def check_credentials_or_client(cls, values: Dict[str, Any]) -> Dict[str, Any]:
client = values.get("client")
url = values.get("url") or os.environ.get("UPSTASH_VECTOR_REST_URL")
token = values.get("token") or os.environ.get("UPSTASH_VECTOR_REST_TOKEN")

if not client and not (url and token):
raise ValueError("Either a client or URL and token must be provided.")
if not client:
url = values.get("url")
if url is None:
url = os.environ.get("UPSTASH_VECTOR_REST_URL")
token = values.get("token")
if token is None:
token = os.environ.get("UPSTASH_VECTOR_REST_TOKEN")

if not (url and token):
raise ValueError("Either a client or URL and token must be provided.")
return values

model_config = ConfigDict(arbitrary_types_allowed=True)