Skip to content

⚡️ Speed up method S3VectorsConfig.validate_extra_fields by 72% #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method S3VectorsConfig.validate_extra_fields by 72% #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions mem0/configs/vector_stores/s3_vectors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,16 @@ class S3VectorsConfig(BaseModel):
@model_validator(mode="before")
@classmethod
def validate_extra_fields(cls, values: Dict[str, Any]) -> Dict[str, Any]:
allowed_fields = set(cls.model_fields.keys())
input_fields = set(values.keys())
extra_fields = input_fields - allowed_fields
# Precompute allowed_fields only once per class for efficiency
if not hasattr(cls, "_allowed_fields_cache"):
# Use tuple instead of set for fixed allowed_fields; should be small and membership is still fast
cls._allowed_fields_cache = tuple(cls.model_fields.keys())
allowed_fields = cls._allowed_fields_cache
# Filter extra fields faster using set difference
extra_fields = set(values) - set(allowed_fields)
if extra_fields:
raise ValueError(
f"Extra fields not allowed: {', '.join(extra_fields)}. Please input only the following fields: {', '.join(allowed_fields)}"
f"Extra fields not allowed: {', '.join(sorted(extra_fields))}. Please input only the following fields: {', '.join(sorted(allowed_fields))}"
)
return values

Expand Down