From 6b48d0ffff99159b79d726145c408cf2bb188c59 Mon Sep 17 00:00:00 2001
From: "codeflash-ai[bot]"
 <148906541+codeflash-ai[bot]@users.noreply.github.com>
Date: Wed, 5 Nov 2025 06:50:26 +0000
Subject: [PATCH] Optimize S3VectorsConfig.validate_extra_fields
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The optimized code achieves a **71% speedup** through class-level caching of allowed fields. The key optimization is storing `cls.model_fields.keys()` in `_allowed_fields_cache` on first access, eliminating repeated computation of the same field names on every validation call.

**Key Changes:**
- **Field Caching**: Uses `hasattr()` check to cache allowed fields as a tuple in `_allowed_fields_cache`, computed only once per class
- **Efficient Set Operations**: Maintains fast set difference operation `set(values) - set(allowed_fields)` for extra field detection
- **Deterministic Output**: Sorts field names in error messages for consistent, testable output

**Why This Works:**
In Pydantic model validation, `cls.model_fields.keys()` accesses the class's field registry every time. For a BaseModel with fixed fields like S3VectorsConfig (5 fields: vector_bucket_name, collection_name, etc.), this is pure overhead. The tuple cache eliminates dictionary attribute access and key extraction on repeated calls, while set conversion for the difference operation remains fast for small field counts.

**Performance Context:**
This optimization is particularly valuable for configuration classes that undergo frequent validation, such as during object initialization or parameter validation in data processing pipelines. The 71% improvement (9.15μs → 5.33μs) compounds significantly when validation occurs in loops or high-frequency operations.
---
 mem0/configs/vector_stores/s3_vectors.py | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/mem0/configs/vector_stores/s3_vectors.py b/mem0/configs/vector_stores/s3_vectors.py
index 4118a40861..252e897fdd 100644
--- a/mem0/configs/vector_stores/s3_vectors.py
+++ b/mem0/configs/vector_stores/s3_vectors.py
@@ -16,12 +16,16 @@ class S3VectorsConfig(BaseModel):
     @model_validator(mode="before")
     @classmethod
     def validate_extra_fields(cls, values: Dict[str, Any]) -> Dict[str, Any]:
-        allowed_fields = set(cls.model_fields.keys())
-        input_fields = set(values.keys())
-        extra_fields = input_fields - allowed_fields
+        # Precompute allowed_fields only once per class for efficiency
+        if not hasattr(cls, "_allowed_fields_cache"):
+            # Use tuple instead of set for fixed allowed_fields; should be small and membership is still fast
+            cls._allowed_fields_cache = tuple(cls.model_fields.keys())
+        allowed_fields = cls._allowed_fields_cache
+        # Filter extra fields faster using set difference
+        extra_fields = set(values) - set(allowed_fields)
         if extra_fields:
             raise ValueError(
-                f"Extra fields not allowed: {', '.join(extra_fields)}. Please input only the following fields: {', '.join(allowed_fields)}"
+                f"Extra fields not allowed: {', '.join(sorted(extra_fields))}. Please input only the following fields: {', '.join(sorted(allowed_fields))}"
             )
         return values