Skip to content

⚡️ Speed up method ElasticsearchConfig.validate_auth by 24% #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method ElasticsearchConfig.validate_auth by 24% #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mem0/configs/vector_stores/elasticsearch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def validate_auth(cls, values: Dict[str, Any]) -> Dict[str, Any]:
raise ValueError("Either cloud_id or host must be provided")

# Check if authentication is provided
if not any([values.get("api_key"), (values.get("user") and values.get("password"))]):
if not (values.get("api_key") or (values.get("user") and values.get("password"))):
raise ValueError("Either api_key or user/password must be provided")

return values
Expand All @@ -43,12 +43,12 @@ def validate_headers(cls, values: Dict[str, Any]) -> Dict[str, Any]:
# Check if headers is a dictionary
if not isinstance(headers, dict):
raise ValueError("headers must be a dictionary")

# Check if all keys and values are strings
for key, value in headers.items():
if not isinstance(key, str) or not isinstance(value, str):
raise ValueError("All header keys and values must be strings")

return values

@model_validator(mode="before")
Expand Down