ready to review

Author: aseembits93

codeflash/api/aiservice.py

@@ -529,24 +529,20 @@ def get_optimization_impact(
         function_trace_id: str,
         coverage_message: str,
         replay_tests: str,
-        concolic_tests: str,
         root_dir: Path,
     ) -> str:
-        """Optimize the given python code for performance by making a request to the Django endpoint.
+        """Compute the optimization impact of current Pull Request.
 
         Args:
-        original_code: dict,
-        new_code: dict,
-        explanation: Explanation,
-        existing_tests_source: str,
-        generated_original_test_source: str,
-        function_trace_id: str,
-        coverage_message: str,
-        replay_tests: str,
-        concolic_tests: str,
-        root_dir: Path,
-        original_line_profiler_results: str,
-        optimized_line_profiler_results: str,
+        original_code: dict -> data structure mapping file paths to function definition for original code
+        new_code: dict -> data structure mapping file paths to function definition for optimized code
+        explanation: Explanation -> data structure containing runtime information
+        existing_tests_source: str -> existing tests table
+        generated_original_test_source: str -> annotated generated tests
+        function_trace_id: str -> traceid of function
+        coverage_message: str -> coverage information
+        replay_tests: str -> replay test table
+        root_dir: Path -> path of git directory
 
         Returns:
         -------
@@ -574,7 +570,6 @@ def get_optimization_impact(
             "trace_id": function_trace_id,
             "coverage_message": coverage_message,
             "replay_tests": replay_tests,
-            "concolic_tests": concolic_tests,
             "speedup": f"{100 + 100 * float(explanation.speedup):.2f}%",
             "loop_count": explanation.winning_benchmarking_test_results.number_of_loops(),
             "benchmark_details": explanation.benchmark_details if explanation.benchmark_details else None,

codeflash/optimization/function_optimizer.py

@@ -1410,12 +1410,14 @@ def process_review(
 
         if raise_pr or staging_review:
             data["root_dir"] = git_root_dir()
-            # modify argument of staging vs pr based on the impact
-            opt_impact_response = self.aiservice_client.get_optimization_impact(**data)
-            if opt_impact_response == "low":
-                raise_pr = False
-                staging_review = True
-
+            try:
+                # modify argument of staging vs pr based on the impact
+                opt_impact_response = self.aiservice_client.get_optimization_impact(**data)
+                if opt_impact_response == "low":
+                    raise_pr = False
+                    staging_review = True
+            except Exception as e:
+                logger.debug(f"optimization impact response failed, investigate {e}")
         if raise_pr and not staging_review:
             data["git_remote"] = self.args.git_remote
             check_create_pr(**data)