Skip to content

Commit 3ba531e

Browse files
committed
fix tests
1 parent 6752e0f commit 3ba531e

File tree

1 file changed

+27
-28
lines changed

1 file changed

+27
-28
lines changed

tests/test_version_check.py

Lines changed: 27 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -120,87 +120,86 @@ def test_get_latest_version_from_pypi_cache_expiry(self, mock_get):
120120
self.assertEqual(mock_get.call_count, 2)
121121

122122
@patch('codeflash.code_utils.version_check.get_latest_version_from_pypi')
123-
@patch('codeflash.code_utils.version_check.console')
123+
@patch('codeflash.code_utils.version_check.logger')
124124
@patch('codeflash.code_utils.version_check.__version__', '1.0.0')
125-
def test_check_for_newer_minor_version_newer_available(self, mock_console, mock_get_version):
125+
def test_check_for_newer_minor_version_newer_available(self, mock_logger,mock_get_version):
126126
"""Test warning message when newer minor version is available."""
127127
mock_get_version.return_value = "1.1.0"
128128

129129
check_for_newer_minor_version()
130130

131-
mock_console.print.assert_called_once()
132-
call_args = mock_console.print.call_args[0][0]
133-
self.assertIn("ℹ️ A newer version of Codeflash is available!", call_args)
134-
self.assertIn("Current version: 1.0.0", call_args)
135-
self.assertIn("Latest version: 1.1.0", call_args)
131+
mock_logger.warning.assert_called_once()
132+
call_args = mock_logger.warning.call_args[0][0]
133+
self.assertIn("of Codeflash is available, please update soon!", call_args)
134+
self.assertIn("1.1.0", call_args)
136135

137136
@patch('codeflash.code_utils.version_check.get_latest_version_from_pypi')
138-
@patch('codeflash.code_utils.version_check.console')
137+
@patch('codeflash.code_utils.version_check.logger')
139138
@patch('codeflash.code_utils.version_check.__version__', '1.0.0')
140-
def test_check_for_newer_minor_version_newer_major_available(self, mock_console, mock_get_version):
139+
def test_check_for_newer_minor_version_newer_major_available(self, mock_logger,mock_get_version):
141140
"""Test warning message when newer major version is available."""
142141
mock_get_version.return_value = "2.0.0"
143142

144143
check_for_newer_minor_version()
145144

146-
mock_console.print.assert_called_once()
147-
call_args = mock_console.print.call_args[0][0]
148-
self.assertIn("ℹ️ A newer version of Codeflash is available!", call_args)
145+
mock_logger.warning.assert_called_once()
146+
call_args = mock_logger.warning.call_args[0][0]
147+
self.assertIn("of Codeflash is available, please update soon!", call_args)
149148

150149
@patch('codeflash.code_utils.version_check.get_latest_version_from_pypi')
151-
@patch('codeflash.code_utils.version_check.console')
150+
@patch('codeflash.code_utils.version_check.logger')
152151
@patch('codeflash.code_utils.version_check.__version__', '1.1.0')
153-
def test_check_for_newer_minor_version_no_newer_available(self, mock_console, mock_get_version):
152+
def test_check_for_newer_minor_version_no_newer_available(self, mock_logger,mock_get_version):
154153
"""Test no warning when no newer version is available."""
155154
mock_get_version.return_value = "1.0.0"
156155

157156
check_for_newer_minor_version()
158157

159-
mock_console.print.assert_not_called()
158+
mock_logger.warning.assert_not_called()
160159

161160
@patch('codeflash.code_utils.version_check.get_latest_version_from_pypi')
162-
@patch('codeflash.code_utils.version_check.console')
163-
@patch('codeflash.code_utils.version_check.__version__', '1.0.0')
164-
def test_check_for_newer_minor_version_patch_update_ignored(self, mock_console, mock_get_version):
161+
@patch('codeflash.code_utils.version_check.logger')
162+
@patch('codeflash.code_utils.version_check.__version__', '1.0.1')
163+
def test_check_for_newer_minor_version_patch_update_ignored(self, mock_logger,mock_get_version):
165164
"""Test that patch updates don't trigger warnings."""
166165
mock_get_version.return_value = "1.0.1"
167166

168167
check_for_newer_minor_version()
169168

170-
mock_console.print.assert_not_called()
169+
mock_logger.warning.assert_not_called()
171170

172171
@patch('codeflash.code_utils.version_check.get_latest_version_from_pypi')
173-
@patch('codeflash.code_utils.version_check.console')
172+
@patch('codeflash.code_utils.version_check.logger')
174173
@patch('codeflash.code_utils.version_check.__version__', '1.0.0')
175-
def test_check_for_newer_minor_version_same_version(self, mock_console, mock_get_version):
174+
def test_check_for_newer_minor_version_same_version(self, mock_logger,mock_get_version):
176175
"""Test no warning when versions are the same."""
177176
mock_get_version.return_value = "1.0.0"
178177

179178
check_for_newer_minor_version()
180179

181-
mock_console.print.assert_not_called()
180+
mock_logger.warning.assert_not_called()
182181

183182
@patch('codeflash.code_utils.version_check.get_latest_version_from_pypi')
184-
@patch('codeflash.code_utils.version_check.console')
183+
@patch('codeflash.code_utils.version_check.logger')
185184
@patch('codeflash.code_utils.version_check.__version__', '1.0.0')
186-
def test_check_for_newer_minor_version_no_latest_version(self, mock_console, mock_get_version):
185+
def test_check_for_newer_minor_version_no_latest_version(self, mock_logger,mock_get_version):
187186
"""Test no warning when latest version cannot be fetched."""
188187
mock_get_version.return_value = None
189188

190189
check_for_newer_minor_version()
191190

192-
mock_console.print.assert_not_called()
191+
mock_logger.warning.assert_not_called()
193192

194193
@patch('codeflash.code_utils.version_check.get_latest_version_from_pypi')
195-
@patch('codeflash.code_utils.version_check.console')
194+
@patch('codeflash.code_utils.version_check.logger')
196195
@patch('codeflash.code_utils.version_check.__version__', '1.0.0')
197-
def test_check_for_newer_minor_version_invalid_version_format(self, mock_console, mock_get_version):
196+
def test_check_for_newer_minor_version_invalid_version_format(self, mock_logger,mock_get_version):
198197
"""Test handling of invalid version format."""
199198
mock_get_version.return_value = "invalid-version"
200199

201200
check_for_newer_minor_version()
202201

203-
mock_console.print.assert_not_called()
202+
mock_logger.warning.assert_not_called()
204203

205204

206205

0 commit comments

Comments
 (0)