Merge branch 'main' into test_cache_revival

Author: KRRT7

codeflash/cli_cmds/cmd_init.py

@@ -155,20 +155,30 @@ def ask_run_end_to_end_test(args: Namespace) -> None:
         run_end_to_end_test(args, bubble_sort_path, bubble_sort_test_path)
 
 
-def is_valid_pyproject_toml(pyproject_toml_path: Path) -> dict[str, Any] | None:
+def is_valid_pyproject_toml(pyproject_toml_path: Path) -> tuple[dict[str, Any] | None, str]:  # noqa: PLR0911
     if not pyproject_toml_path.exists():
-        return None
+        return None, f"Configuration file not found: {pyproject_toml_path}"
+
     try:
         config, _ = parse_config_file(pyproject_toml_path)
-    except Exception:
-        return None
+    except Exception as e:
+        return None, f"Failed to parse configuration: {e}"
+
+    module_root = config.get("module_root")
+    if not module_root:
+        return None, "Missing required field: 'module_root'"
+
+    if not Path(module_root).is_dir():
+        return None, f"Invalid 'module_root': directory does not exist at {module_root}"
+
+    tests_root = config.get("tests_root")
+    if not tests_root:
+        return None, "Missing required field: 'tests_root'"
 
-    if "module_root" not in config or config["module_root"] is None or not Path(config["module_root"]).is_dir():
-        return None
-    if "tests_root" not in config or config["tests_root"] is None or not Path(config["tests_root"]).is_dir():
-        return None
+    if not Path(tests_root).is_dir():
+        return None, f"Invalid 'tests_root': directory does not exist at {tests_root}"
 
-    return config
+    return config, ""
 
 
 def should_modify_pyproject_toml() -> tuple[bool, dict[str, Any] | None]:
@@ -180,7 +190,7 @@ def should_modify_pyproject_toml() -> tuple[bool, dict[str, Any] | None]:
 
     pyproject_toml_path = Path.cwd() / "pyproject.toml"
 
-    config = is_valid_pyproject_toml(pyproject_toml_path)
+    config, _message = is_valid_pyproject_toml(pyproject_toml_path)
     if config is None:
         return True, None
 
@@ -631,7 +641,7 @@ def check_for_toml_or_setup_file() -> str | None:
 
 def install_github_actions(override_formatter_check: bool = False) -> None:  # noqa: FBT001, FBT002
     try:
-        config, config_file_path = parse_config_file(override_formatter_check=override_formatter_check)
+        config, _config_file_path = parse_config_file(override_formatter_check=override_formatter_check)
 
         ph("cli-github-actions-install-started")
         try:

codeflash/lsp/beta.py

@@ -191,10 +191,10 @@ def init_project(server: CodeflashLanguageServer, params: ValidateProjectParams)
         }
 
     server.show_message_log("Validating project...", "Info")
-    config = is_valid_pyproject_toml(pyproject_toml_path)
+    config, reason = is_valid_pyproject_toml(pyproject_toml_path)
     if config is None:
         server.show_message_log("pyproject.toml is not valid", "Error")
-        return {"status": "error", "message": "not valid", "pyprojectPath": pyproject_toml_path}
+        return {"status": "error", "message": f"reason: {reason}", "pyprojectPath": pyproject_toml_path}
 
     args = process_args(server)
 

docs/optimizing-with-codeflash/codeflash-github-actions.mdx

@@ -5,17 +5,16 @@ icon: "github"
 ---
 
 
-Optimizing new code in Pull Requests is the best way to ensure that all code you and your team ship is performant
-in the future. Automating optimization in the Pull Request stage how most teams use Codeflash, to
+Optimizing new code in Pull Requests is the best way to ensure that all code you and your team ship is always performant.
+Automating optimization in the Pull Request stage is how most teams use Codeflash, to
 continuously find optimizations for their new code.
 
 To scan new code for performance optimizations, Codeflash uses a GitHub Action workflow which runs
 the Codeflash optimization logic on the new code in every pull request.
 If the action workflow finds an optimization, it communicates with the Codeflash GitHub 
 App and asks it to suggest new changes to the pull request.
 
-This is the most useful way of using Codeflash, where you set it up once and all your new code gets optimized.
-So setting this up is highly recommended.
+We highly recommend setting this up, since once you set it up all your new code gets optimized.
 
 ## Pull Request Optimization 30 seconds demo
 <iframe width="640" height="400" src="https://www.youtube.com/embed/nqa-uewizkU?si=H1wb1RvPp-JqvKPh" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" allowfullscreen></iframe>
@@ -68,8 +67,15 @@ name: Codeflash
 
 on:
   pull_request:
+    paths:
+      - '**'  # Modify this to the path of your project in a mono-repo. Codeflash will only run when code in this directory is modified.
   workflow_dispatch:
 
+concurrency:
+  # Any new push to the PR will cancel the previous run, so that only the latest code is optimized
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   optimize:
     name: Optimize new code in this PR
@@ -103,11 +109,17 @@ jobs:
 <Warning>
 **Replace the TODOs** in the workflow file above with your project's specific setup commands.
 </Warning>
+  Set the `working-directory` parameter in the yaml file, if the commands are meant to be run from some other directory.
 </Step>
 
 <Step title="Choose Your Package Manager">
 Customize the dependency installation based on your Python package manager:
 
+The workflow will need to be set up in such a way the Codeflash can create and
+run tests for functionality and speed, so the stock YAML may need to be altered to
+suit the specific codebase. Typically the setup steps for a unit test workflow can
+be copied.
+
 <CodeGroup>
 ```yaml Poetry
 - name: Install Project Dependencies