refactor: update MoveGitToTemp to use oldGitPath directly for restoring git binary

ryan-gang · ryan-gang · commit a709cef39d75 · 2025-07-03T23:44:07.000+05:30
diff --git a/internal/utils.go b/internal/utils.go
@@ -17,7 +17,6 @@ func MoveGitToTemp(harness *test_case_harness.TestCaseHarness, logger *logger.Lo
 	if err != nil {
 		panic(fmt.Sprintf("CodeCrafters Internal Error: git executable not found: %v", err))
 	}
-	oldGitDir := path.Dir(oldGitPath)
 
 	tmpGitDir, err := os.MkdirTemp("/tmp", "git-*")
 	if err != nil {
@@ -35,7 +34,7 @@ func MoveGitToTemp(harness *test_case_harness.TestCaseHarness, logger *logger.Lo
 	}
 
 	// Register teardown function to automatically restore git
-	harness.RegisterTeardownFunc(func() { restoreGit(tmpGitPath, oldGitDir) })
+	harness.RegisterTeardownFunc(func() { restoreGit(tmpGitPath, oldGitPath) })
 }
 
 // RestoreGit moves the git binary back to its original location and cleans up

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@ func MoveGitToTemp(harness test_case_harness.TestCaseHarness, logger logger.Lo`
`17`	`17`	`if err != nil {`
`18`	`18`	`panic(fmt.Sprintf("CodeCrafters Internal Error: git executable not found: %v", err))`
`19`	`19`	`}`
`20`		`- oldGitDir := path.Dir(oldGitPath)`
`21`	`20`
`22`	`21`	`tmpGitDir, err := os.MkdirTemp("/tmp", "git-*")`
`23`	`22`	`if err != nil {`
`@@ -35,7 +34,7 @@ func MoveGitToTemp(harness test_case_harness.TestCaseHarness, logger logger.Lo`
`35`	`34`	`}`
`36`	`35`
`37`	`36`	`// Register teardown function to automatically restore git`
`38`		`- harness.RegisterTeardownFunc(func() { restoreGit(tmpGitPath, oldGitDir) })`
	`37`	`+ harness.RegisterTeardownFunc(func() { restoreGit(tmpGitPath, oldGitPath) })`
`39`	`38`	`}`
`40`	`39`
`41`	`40`	`// RestoreGit moves the git binary back to its original location and cleans up`