Skip to content

Commit 58056e1

Browse files
authored
Merge pull request #438 from codecrafters-io/andy/tweak
Improve Redis stage 2 solutions for JS and TS
2 parents fe2aace + d2805f9 commit 58056e1

File tree

4 files changed

+16
-6
lines changed

4 files changed

+16
-6
lines changed

solutions/javascript/02-rg2/code/app/main.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@ const net = require("net");
22

33
const server = net.createServer((connection) => {
44
// Handle connection
5-
connection.write(`+PONG\r\n`);
5+
connection.on("data", (data) => {
6+
connection.write(`+PONG\r\n`);
7+
});
68
});
79

810
server.listen(6379, "127.0.0.1");
Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
1-
@@ -1,7 +1,8 @@
1+
@@ -1,7 +1,10 @@
22
const net = require("net");
33

44
const server = net.createServer((connection) => {
55
// Handle connection
6-
+ connection.write(`+PONG\r\n`);
6+
+ connection.on("data", (data) => {
7+
+ connection.write(`+PONG\r\n`);
8+
+ });
79
});
810

911
server.listen(6379, "127.0.0.1");
Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
import * as net from "net";
2+
import { Buffer } from "buffer";
23

34
const server: net.Server = net.createServer((connection: net.Socket) => {
45
// Handle connection
5-
connection.write(`+PONG\r\n`);
6+
connection.on("data", (data: Buffer) => {
7+
connection.write(`+PONG\r\n`);
8+
});
69
});
710

811
server.listen(6379, "127.0.0.1");
Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
1-
@@ -1,7 +1,8 @@
1+
@@ -1,7 +1,11 @@
22
import * as net from "net";
3+
+import { Buffer } from "buffer";
34

45
const server: net.Server = net.createServer((connection: net.Socket) => {
56
// Handle connection
6-
+ connection.write(`+PONG\r\n`);
7+
+ connection.on("data", (data: Buffer) => {
8+
+ connection.write(`+PONG\r\n`);
9+
+ });
710
});
811

912
server.listen(6379, "127.0.0.1");

0 commit comments

Comments
 (0)