feat: use ascii control char US to separate the class name and test name when parsing junit

Author: joseph-sentry

src/junit.rs

@@ -3,6 +3,7 @@ use pyo3::prelude::*;
 use quick_xml::events::attributes::Attributes;
 use quick_xml::events::Event;
 use quick_xml::reader::Reader;
+use std::ascii;
 use std::collections::HashMap;
 
 use crate::helpers::ParserError;
@@ -24,10 +25,11 @@ fn attributes_map(attributes: Attributes) -> Result<HashMap<String, String>, pyo
 
 fn populate(attr_hm: &HashMap<String, String>, testsuite: String) -> Result<Testrun, pyo3::PyErr> {
     let name = format!(
-        "{}::{}",
+        "{}{}{}",
         attr_hm
             .get("classname")
             .ok_or(ParserError::new_err("No classname found"))?,
+        '\x1f',
         attr_hm
             .get("name")
             .ok_or(ParserError::new_err("No name found"))?

tests/test_junit.py

@@ -1,5 +1,5 @@
 import pytest
-from test_results_parser import parse_junit_xml, Testrun, Outcome
+from test_results_parser import Outcome, Testrun, parse_junit_xml
 
 
 class TestParsers:
@@ -10,7 +10,7 @@ class TestParsers:
                 "./tests/junit.xml",
                 [
                     Testrun(
-                        "tests.test_parsers.TestParsers::test_junit[junit.xml--True]",
+                        "tests.test_parsers.TestParsers\x1ftest_junit[junit.xml--True]",
                         0.001,
                         Outcome.Failure,
                         "pytest",
@@ -32,7 +32,7 @@ def test_junit(self, filename, expected, check):
 tests/test_parsers.py:16: AssertionError""",
                     ),
                     Testrun(
-                        "tests.test_parsers.TestParsers::test_junit[jest-junit.xml--False]",
+                        "tests.test_parsers.TestParsers\x1ftest_junit[jest-junit.xml--False]",
                         0.064,
                         Outcome.Pass,
                         "pytest",
@@ -44,28 +44,28 @@ def test_junit(self, filename, expected, check):
                 "./tests/jest-junit.xml",
                 [
                     Testrun(
-                        "Title when rendered renders pull title::Title when rendered renders pull title",
+                        "Title when rendered renders pull title\x1fTitle when rendered renders pull title",
                         0.036,
                         Outcome.Pass,
                         "Title",
                         None,
                     ),
                     Testrun(
-                        "Title when rendered renders pull author::Title when rendered renders pull author",
+                        "Title when rendered renders pull author\x1fTitle when rendered renders pull author",
                         0.005,
                         Outcome.Pass,
                         "Title",
                         None,
                     ),
                     Testrun(
-                        "Title when rendered renders pull updatestamp::Title when rendered renders pull updatestamp",
+                        "Title when rendered renders pull updatestamp\x1fTitle when rendered renders pull updatestamp",
                         0.002,
                         Outcome.Pass,
                         "Title",
                         None,
                     ),
                     Testrun(
-                        "Title when rendered for first pull request renders pull title::Title when rendered for first pull request renders pull title",
+                        "Title when rendered for first pull request renders pull title\x1fTitle when rendered for first pull request renders pull title",
                         0.006,
                         Outcome.Pass,
                         "Title",
@@ -77,15 +77,15 @@ def test_junit(self, filename, expected, check):
                 "./tests/vitest-junit.xml",
                 [
                     Testrun(
-                        "__tests__/test-file-1.test.ts::first test file > 2 + 2 should equal 4",
+                        "__tests__/test-file-1.test.ts\x1ffirst test file > 2 + 2 should equal 4",
                         0.01,
                         Outcome.Failure,
                         "__tests__/test-file-1.test.ts",
                         """AssertionError: expected 5 to be 4 // Object.is equality
  ❯ __tests__/test-file-1.test.ts:20:28""",
                     ),
                     Testrun(
-                        "__tests__/test-file-1.test.ts::first test file > 4 - 2 should equal 2",
+                        "__tests__/test-file-1.test.ts\x1ffirst test file > 4 - 2 should equal 2",
                         0,
                         Outcome.Pass,
                         "__tests__/test-file-1.test.ts",
@@ -97,20 +97,20 @@ def test_junit(self, filename, expected, check):
                 "./tests/empty_failure.junit.xml",
                 [
                     Testrun(
-                        "test.test::test.test works",
+                        "test.test\x1ftest.test works",
                         0.234,
                         Outcome.Pass,
                         "test",
-                        None
+                        None,
                     ),
-                    Testrun(    
-                        "test.test::test.test fails",
+                    Testrun(
+                        "test.test\x1ftest.test fails",
                         1,
                         Outcome.Failure,
                         "test",
-                        "TestError"
+                        "TestError",
                     ),
-                ]
+                ],
             ),
         ],
     )
@@ -120,4 +120,3 @@ def test_junit(self, filename, expected):
             assert len(res) == len(expected)
             for restest, extest in zip(res, expected):
                 assert restest == extest
-