working version 1.0.0

Author: Bernhard Grünewaldt

DEVELOPMENT.md

@@ -8,3 +8,11 @@ curl -X POST \
     -d @test-webhook-payload.json \
     http://localhost:8080/jenkins/plugin/github-webhook-notifier-plugin/receive
 ```
+
+### Build hpi
+
+```
+mvn clean
+mvn compile
+mvn hpi:hpi
+```

README.md

@@ -2,6 +2,9 @@
 jenkins-github-webhook-notifier-plugin
 
 
+
+ * Plugin does allow self signed certificates and does not check the SSL Cert of `Jenkins.getInstance().getRootUrl();`
+
 -----
 
  

pom.xml

@@ -11,7 +11,7 @@
   </parent>
   <groupId>io.codeclou.jenkins.github.webhook.notifier.plugin</groupId>
   <artifactId>github-webhook-notifier-plugin</artifactId>
-  <version>1.0-SNAPSHOT</version>
+  <version>1.0.0</version>
   <packaging>hpi</packaging>
 
   <name>github-webhook-notifier-plugin</name>
@@ -41,5 +41,16 @@
       <artifactId>gson</artifactId>
       <version>2.8.0</version>
     </dependency>
+
+    <dependency>
+      <groupId>org.apache.httpcomponents</groupId>
+      <artifactId>httpclient</artifactId>
+      <version>4.5.3</version>
+    </dependency>
+    <dependency>
+      <groupId>commons-io</groupId>
+      <artifactId>commons-io</artifactId>
+      <version>2.5</version>
+    </dependency>
   </dependencies>
 </project>

src/main/java/io/codeclou/jenkins/github/webhook/notifier/plugin/GithubWebhookNotifierPlugin.java

@@ -9,17 +9,28 @@
 import hudson.Plugin;
 import hudson.util.HttpResponses;
 import jenkins.model.Jenkins;
-import org.apache.commons.httpclient.HttpClient;
-import org.apache.commons.httpclient.HttpMethod;
-import org.apache.commons.httpclient.methods.GetMethod;
+import org.apache.commons.io.IOUtils;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpGet;
+import org.apache.http.conn.ssl.NoopHostnameVerifier;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.http.ssl.SSLContextBuilder;
+import org.apache.http.ssl.TrustStrategy;
 import org.kohsuke.stapler.HttpResponse;
 import org.kohsuke.stapler.StaplerRequest;
 import org.kohsuke.stapler.interceptor.RequirePOST;
 
+import javax.net.ssl.SSLContext;
 import javax.servlet.ServletException;
 import javax.servlet.http.HttpServletRequest;
 import java.io.BufferedReader;
 import java.io.IOException;
+import java.security.KeyManagementException;
+import java.security.KeyStoreException;
+import java.security.NoSuchAlgorithmException;
+import java.security.cert.CertificateException;
+import java.security.cert.X509Certificate;
 
 
 public class GithubWebhookNotifierPlugin extends Plugin {
@@ -36,22 +47,40 @@ public HttpResponse doReceive(HttpServletRequest request, StaplerRequest stapler
             GithubWebhookPayload githubWebhookPayload = gson.fromJson(reader, GithubWebhookPayload.class);
             // Trigger Git-Plugins notify push SCM Polling Endpoint
             String gitPluginNotifyUrl = jenkinsRootUrl +
-                    "git/notifyCommit?" +
+                    "git/notifyCommit?url=" +
                     githubWebhookPayload.getRepository().getClone_url() +
                     "&branches=" +
                     githubWebhookPayload.getRef() +
                     "&sha1=" +
                     githubWebhookPayload.getAfter();
-            HttpClient client = new HttpClient();
-            HttpMethod method = new GetMethod(gitPluginNotifyUrl);
-            int statusCode = client.executeMethod(method);
-            String responseText = "triggered: " + gitPluginNotifyUrl + "\nstatus: " + statusCode;
+            SSLContext sslContext = new SSLContextBuilder()
+                    .loadTrustMaterial(null, new TrustStrategy() {
+                        @Override
+                        public boolean isTrusted(X509Certificate[] certificate, String authType) throws CertificateException {
+                            return true;
+                        }
+                    }).build();
+            CloseableHttpClient client = HttpClients.custom()
+                    .setSSLContext(sslContext)
+                    .setSSLHostnameVerifier(new NoopHostnameVerifier())
+                    .build();
+            HttpGet httpGet = new HttpGet(gitPluginNotifyUrl);
+            CloseableHttpResponse response = client.execute(httpGet);
+            int statusCode = response.getStatusLine().getStatusCode();
+            String gitNotificationResponse = IOUtils.toString(response.getEntity().getContent(), "UTF-8");
+            String responseText = "ok triggered: " + gitPluginNotifyUrl + "\nstatus: " + statusCode + "\n\n" + gitNotificationResponse;
             if (statusCode != 200) {
                 return HttpResponses.error(400, responseText);
             }
             return HttpResponses.plainText(responseText);
         } catch (JsonSyntaxException ex) {
             return HttpResponses.error(500, "json invalid");
+        } catch (NoSuchAlgorithmException ex) {
+            return HttpResponses.error(500, "NoSuchAlgorithmException");
+        } catch (KeyStoreException ex) {
+            return HttpResponses.error(500, "KeyStoreException");
+        } catch (KeyManagementException ex) {
+            return HttpResponses.error(500, "KeyManagementException");
         }
     }
 }