Update rubocop to 1.32.0 (#325)

- General bundle update.
- Update the docs too.

Author: BrianHawley

Gemfile

@@ -6,7 +6,7 @@ gem "activesupport", require: false
 gem "mry", require: false
 gem "parser"
 gem "pry", require: false
-gem "rubocop", "1.31.0", require: false
+gem "rubocop", "1.32.0", require: false
 gem "rubocop-i18n", require: false
 gem "rubocop-graphql", require: false
 gem "rubocop-minitest", require: false

Gemfile.lock

@@ -1,7 +1,7 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.0.3)
+    activesupport (7.0.3.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
@@ -10,10 +10,11 @@ GEM
     coderay (1.1.3)
     concurrent-ruby (1.1.10)
     diff-lcs (1.5.0)
-    i18n (1.10.0)
+    i18n (1.12.0)
       concurrent-ruby (~> 1.0)
+    json (2.6.2)
     method_source (1.0.0)
-    minitest (5.16.1)
+    minitest (5.16.2)
     mry (0.78.0.0)
       rubocop (>= 0.41.0)
     parallel (1.22.1)
@@ -22,7 +23,7 @@ GEM
     pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    rack (2.2.3.1)
+    rack (2.2.4)
     rainbow (3.1.1)
     rake (13.0.6)
     regexp_parser (2.5.0)
@@ -40,45 +41,46 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.11.0)
     rspec-support (3.11.0)
-    rubocop (1.31.0)
+    rubocop (1.32.0)
+      json (~> 2.3)
       parallel (~> 1.10)
       parser (>= 3.1.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.18.0, < 2.0)
+      rubocop-ast (>= 1.19.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.18.0)
+    rubocop-ast (1.19.1)
       parser (>= 3.1.1.0)
     rubocop-graphql (0.14.4)
       rubocop (>= 0.87, < 2)
     rubocop-i18n (3.0.0)
       rubocop (~> 1.0)
     rubocop-minitest (0.20.1)
       rubocop (>= 0.90, < 2.0)
-    rubocop-performance (1.14.2)
+    rubocop-performance (1.14.3)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    rubocop-rails (2.15.1)
+    rubocop-rails (2.15.2)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.7.0, < 2.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-    rubocop-rspec (2.11.1)
-      rubocop (~> 1.19)
+    rubocop-rspec (2.12.1)
+      rubocop (~> 1.31)
     rubocop-sequel (0.3.4)
       rubocop (~> 1.0)
-    rubocop-shopify (2.7.1)
-      rubocop (~> 1.30)
-    rubocop-sorbet (0.6.10)
+    rubocop-shopify (2.8.0)
+      rubocop (~> 1.31)
+    rubocop-sorbet (0.6.11)
       rubocop (>= 0.90.0)
     rubocop-thread_safety (0.4.4)
       rubocop (>= 0.53.0)
     ruby-progressbar (1.11.0)
     test-prof (1.0.9)
-    tzinfo (2.0.4)
+    tzinfo (2.0.5)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.2.0)
 
@@ -92,7 +94,7 @@ DEPENDENCIES
   pry
   rake
   rspec
-  rubocop (= 1.31.0)
+  rubocop (= 1.32.0)
   rubocop-graphql
   rubocop-i18n
   rubocop-minitest

config/contents/layout/line_continuation_leading_space.md

@@ -1,7 +1,8 @@
 Checks that strings broken over multiple lines (by a backslash) contain
-trailing spaces instead of leading spaces.
+trailing spaces instead of leading spaces (default) or leading spaces
+instead of trailing spaces.
 
-### Example:
+### Example: EnforcedStyle: trailing (default)
     # bad
     'this text contains a lot of' \
     '               spaces'
@@ -17,3 +18,20 @@ trailing spaces instead of leading spaces.
     # good
     'this text is too ' \
     'long'
+
+### Example: EnforcedStyle: leading
+    # bad
+    'this text contains a lot of               ' \
+    'spaces'
+
+    # good
+    'this text contains a lot of' \
+    '               spaces'
+
+    # bad
+    'this text is too ' \
+    'long'
+
+    # good
+    'this text is too' \
+    ' long'

config/contents/layout/line_length.md

@@ -30,6 +30,7 @@ are recommended to further format the broken lines.
 * MultilineHashBraceLayout
 * MultilineHashKeyLineBreaks
 * MultilineMethodArgumentLineBreaks
+* MultilineMethodParameterLineBreaks
 * ParameterAlignment
 
 Together, these cops will pretty print hashes, arrays,

config/contents/layout/multiline_method_argument_line_breaks.md

@@ -1,7 +1,7 @@
 Ensures that each argument in a multi-line method call
 starts on a separate line.
 
-NOTE: this cop does not move the first argument, if you want that to
+NOTE: This cop does not move the first argument, if you want that to
 be on a separate line, see `Layout/FirstMethodArgumentLineBreak`.
 
 ### Example:
@@ -16,4 +16,7 @@ be on a separate line, see `Layout/FirstMethodArgumentLineBreak`.
       a,
       b,
       c
-    )
+    )
+
+    # good
+    foo(a, b, c)

config/contents/layout/multiline_method_parameter_line_breaks.md

@@ -0,0 +1,25 @@
+Ensures that each parameter in a multi-line method definition
+starts on a separate line.
+
+NOTE: This cop does not move the first argument, if you want that to
+be on a separate line, see `Layout/FirstMethodParameterLineBreak`.
+
+### Example:
+
+    # bad
+    def foo(a, b,
+      c
+    )
+    end
+
+    # good
+    def foo(
+      a,
+      b,
+      c
+    )
+    end
+
+    # good
+    def foo(a, b, c)
+    end

config/contents/lint/ambiguous_block_association.md

@@ -2,6 +2,7 @@ Checks for ambiguous block association with method
 when param passed without parentheses.
 
 This cop can customize ignored methods with `IgnoredMethods`.
+By default, there are no methods to ignored.
 
 ### Example:
 
@@ -24,7 +25,12 @@ This cop can customize ignored methods with `IgnoredMethods`.
     # Lambda arguments require no disambiguation
     foo = ->(bar) { bar.baz }
 
+### Example: IgnoredMethods: [] (default)
+
+    # bad
+    expect { do_something }.to change { object.attribute }
+
 ### Example: IgnoredMethods: [change]
 
     # good
-    expect { do_something }.to change { object.attribute }
+    expect { do_something }.to change { object.attribute }

config/contents/lint/deprecated_class_methods.md

@@ -3,21 +3,21 @@ Checks for uses of the deprecated class method usages.
 ### Example:
 
     # bad
-
     File.exists?(some_path)
     Dir.exists?(some_path)
     iterator?
     ENV.freeze # Calling `Env.freeze` raises `TypeError` since Ruby 2.7.
+    ENV.clone
+    ENV.dup # Calling `Env.dup` raises `TypeError` since Ruby 3.1.
     Socket.gethostbyname(host)
     Socket.gethostbyaddr(host)
 
-### Example:
-
     # good
-
     File.exist?(some_path)
     Dir.exist?(some_path)
     block_given?
     ENV # `ENV.freeze` cannot prohibit changes to environment variables.
+    ENV.to_h
+    ENV.to_h # `ENV.dup` cannot dup `ENV`, use `ENV.to_h` to get a copy of `ENV` as a hash.
     Addrinfo.getaddrinfo(nodename, service)
     Addrinfo.tcp(host, port).getnameinfo

config/contents/lint/literal_as_condition.md

@@ -2,6 +2,9 @@ Checks for literals used as the conditions or as
 operands in and/or expressions serving as the conditions of
 if/while/until/case-when/case-in.
 
+NOTE: Literals in `case-in` condition where the match variable is used in
+`in` are accepted as a pattern matching.
+
 ### Example:
 
     # bad

config/contents/lint/non_atomic_file_operation.md

@@ -21,16 +21,18 @@ The atomic processing of the replacement destination is not guaranteed
 to be strictly equivalent to that before the replacement.
 
 ### Example:
-    # bad
-    unless FileTest.exist?(path)
-      FileUtils.makedirs(path)
+    # bad - race condition with another process may result in an error in `mkdir`
+    unless Dir.exist?(path)
+      FileUtils.mkdir(path)
     end
 
-    if FileTest.exist?(path)
+    # good - atomic and idempotent creation
+    FileUtils.mkdir_p(path)
+
+    # bad - race condition with another process may result in an error in `remove`
+    if File.exist?(path)
       FileUtils.remove(path)
     end
 
-    # good
-    FileUtils.mkdir_p(path)
-
-    FileUtils.rm_rf(path)
+    # good - atomic and idempotent removal
+    FileUtils.rm_f(path)