Update PHP badge color and coverage percentage, improve file handling

Author: mohanrajpac

badges/php.svg

@@ -31,7 +31,8 @@
     "scripts": {
         "lint": "phpcs",
         "lint:fix": "phpcbf",
-        "test": "phpunit --testdox --coverage-clover coverage/clover.xml --coverage-html coverage --coverage-filter src/"
+        "test": "phpunit --testdox --coverage-clover coverage/clover.xml --coverage-html coverage --coverage-filter src/",
+        "php:badge": "bin/coverage-badge coverage/clover.xml badges/php.svg PHP"
     },
     "config": {
         "allow-plugins": {

composer.json

@@ -101,7 +101,11 @@ public function run(): void
     private function processFile(string $inputFile): void
     {
         try {
-            $xml = new SimpleXMLElement(file_get_contents($inputFile));
+            $content = file_get_contents($inputFile);
+            if ($content === false) {
+                throw new Exception('Error reading file: ' . $inputFile);
+            }
+            $xml = new SimpleXMLElement($content);
             $metrics = $xml->xpath('//metrics');
             foreach ($metrics as $metric) {
                 $this->totalElements   += (int) $metric['elements'];
@@ -112,7 +116,7 @@ private function processFile(string $inputFile): void
             $this->totalCoverage += (int) round($coverageRatio * 100);
 
         } catch (Throwable $e) {
-            throw new Exception('Error processing file: ' . $e->getMessage());
+            throw new Exception($e->getMessage());
         }
     }
 

src/BadgeComposer.php

@@ -15,7 +15,7 @@ class BadgeComposerTest extends TestCase
 
     private string $inputFile = __DIR__ . "/test-input1.xml";
     private string $inputFile2 = __DIR__ . "/test-input2.xml";
-    private string $outputFile = "output.svg";
+    private string $outputFile = __DIR__ . "/../badges/output.svg";
     private string $coverageName = "unit";
 
     /**
@@ -97,4 +97,38 @@ public function testProcessMultipleCloverFilesAndCalculateTheCoverage(): void
         $this->assertEquals(83, $this->badgeComposer->getTotalCoverage());
     }
 
+    /**
+     * @throws ReflectionException
+     */
+    public function testItThrowsExceptionWhenFileProcessingFails(): void
+    {
+        $this->expectException(Throwable::class);
+        $this->expectExceptionMessage('Error reading file: invalid_file.xml');
+
+        $this->processFile('invalid_file.xml');
+    }
+
+    /**
+     * @throws ReflectionException
+     */
+    public function finalizeCoverage()
+    {
+        $method = (new ReflectionClass($this->badgeComposer))->getMethod('finalizeCoverage');
+
+        return $method->invoke($this->badgeComposer);
+    }
+
+    /**
+     * @throws ReflectionException
+     */
+    public function testFinalizeCoverageCalculatesAverageCoverage(): void
+    {
+        $this->finalizeCoverage();
+
+        $outputFileContent = file_get_contents(__DIR__ . "/../badges/output.svg");
+        $this->assertStringContainsString('#e05d44', $outputFileContent);
+
+        $this->assertStringContainsString('unit', $outputFileContent);
+    }
+
 }