Skip to content

Commit c8ec6ad

Browse files
committed
refactor(GuiceInjector): Rename variable and update references for clarity
1 parent 7e594e5 commit c8ec6ad

File tree

5 files changed

+18
-20
lines changed

5 files changed

+18
-20
lines changed

src/main/java/com/github/codeboyzhou/mcp/declarative/common/GuiceInjectorModule.java

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -21,21 +21,20 @@
2121

2222
public final class GuiceInjectorModule extends AbstractModule {
2323

24-
public static final String VARIABLE_NAME_I18N_ENABLED = "i18nEnabled";
24+
public static final String INJECTED_VARIABLE_NAME_I18N_ENABLED = "i18nEnabled";
2525

26-
private final Class<?> applicationMainClass;
26+
private final Class<?> mainClass;
2727

28-
public GuiceInjectorModule(Class<?> applicationMainClass) {
29-
this.applicationMainClass = applicationMainClass;
28+
public GuiceInjectorModule(Class<?> mainClass) {
29+
this.mainClass = mainClass;
3030
}
3131

3232
@Provides
3333
@Singleton
3434
@SuppressWarnings("unused")
3535
public Reflections provideReflections() {
36-
McpServerApplication application =
37-
applicationMainClass.getAnnotation(McpServerApplication.class);
38-
final String basePackage = determineBasePackage(application, applicationMainClass);
36+
McpServerApplication application = mainClass.getAnnotation(McpServerApplication.class);
37+
final String basePackage = determineBasePackage(application);
3938
return new Reflections(basePackage, TypesAnnotated, MethodsAnnotated, FieldsAnnotated);
4039
}
4140

@@ -55,14 +54,13 @@ protected void configure() {
5554
bind(McpServerToolFactory.class).in(SINGLETON);
5655

5756
// Bind for boolean variable: i18nEnabled
58-
final boolean i18nEnabled = applicationMainClass.isAnnotationPresent(McpI18nEnabled.class);
57+
final boolean i18nEnabled = mainClass.isAnnotationPresent(McpI18nEnabled.class);
5958
bind(Boolean.class)
60-
.annotatedWith(Names.named(VARIABLE_NAME_I18N_ENABLED))
59+
.annotatedWith(Names.named(INJECTED_VARIABLE_NAME_I18N_ENABLED))
6160
.toInstance(i18nEnabled);
6261
}
6362

64-
private String determineBasePackage(
65-
McpServerApplication application, Class<?> applicationMainClass) {
63+
private String determineBasePackage(McpServerApplication application) {
6664
if (application != null) {
6765
if (!application.basePackage().trim().isBlank()) {
6866
return application.basePackage();
@@ -71,6 +69,6 @@ private String determineBasePackage(
7169
return application.basePackageClass().getPackageName();
7270
}
7371
}
74-
return applicationMainClass.getPackageName();
72+
return mainClass.getPackageName();
7573
}
7674
}

src/main/java/com/github/codeboyzhou/mcp/declarative/server/factory/AbstractMcpServerComponentFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.github.codeboyzhou.mcp.declarative.server.factory;
22

3-
import static com.github.codeboyzhou.mcp.declarative.common.GuiceInjectorModule.VARIABLE_NAME_I18N_ENABLED;
3+
import static com.github.codeboyzhou.mcp.declarative.common.GuiceInjectorModule.INJECTED_VARIABLE_NAME_I18N_ENABLED;
44

55
import com.github.codeboyzhou.mcp.declarative.util.StringHelper;
66
import com.google.inject.Injector;
@@ -26,7 +26,7 @@ public abstract class AbstractMcpServerComponentFactory<T> implements McpServerC
2626
private final ResourceBundle bundle;
2727

2828
protected AbstractMcpServerComponentFactory(
29-
Injector injector, @Named(VARIABLE_NAME_I18N_ENABLED) Boolean i18nEnabled) {
29+
Injector injector, @Named(INJECTED_VARIABLE_NAME_I18N_ENABLED) Boolean i18nEnabled) {
3030
this.injector = injector;
3131
this.i18nEnabled = i18nEnabled;
3232
this.bundle = loadResourceBundle();

src/main/java/com/github/codeboyzhou/mcp/declarative/server/factory/McpServerPromptFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.github.codeboyzhou.mcp.declarative.server.factory;
22

3-
import static com.github.codeboyzhou.mcp.declarative.common.GuiceInjectorModule.VARIABLE_NAME_I18N_ENABLED;
3+
import static com.github.codeboyzhou.mcp.declarative.common.GuiceInjectorModule.INJECTED_VARIABLE_NAME_I18N_ENABLED;
44

55
import com.github.codeboyzhou.mcp.declarative.annotation.McpPrompt;
66
import com.github.codeboyzhou.mcp.declarative.annotation.McpPromptParam;
@@ -35,7 +35,7 @@ public class McpServerPromptFactory
3535

3636
@Inject
3737
protected McpServerPromptFactory(
38-
Injector injector, @Named(VARIABLE_NAME_I18N_ENABLED) Boolean i18nEnabled) {
38+
Injector injector, @Named(INJECTED_VARIABLE_NAME_I18N_ENABLED) Boolean i18nEnabled) {
3939
super(injector, i18nEnabled);
4040
}
4141

src/main/java/com/github/codeboyzhou/mcp/declarative/server/factory/McpServerResourceFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.github.codeboyzhou.mcp.declarative.server.factory;
22

3-
import static com.github.codeboyzhou.mcp.declarative.common.GuiceInjectorModule.VARIABLE_NAME_I18N_ENABLED;
3+
import static com.github.codeboyzhou.mcp.declarative.common.GuiceInjectorModule.INJECTED_VARIABLE_NAME_I18N_ENABLED;
44

55
import com.github.codeboyzhou.mcp.declarative.annotation.McpResource;
66
import com.github.codeboyzhou.mcp.declarative.annotation.McpResources;
@@ -28,7 +28,7 @@ public class McpServerResourceFactory
2828

2929
@Inject
3030
protected McpServerResourceFactory(
31-
Injector injector, @Named(VARIABLE_NAME_I18N_ENABLED) Boolean i18nEnabled) {
31+
Injector injector, @Named(INJECTED_VARIABLE_NAME_I18N_ENABLED) Boolean i18nEnabled) {
3232
super(injector, i18nEnabled);
3333
}
3434

src/main/java/com/github/codeboyzhou/mcp/declarative/server/factory/McpServerToolFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.github.codeboyzhou.mcp.declarative.server.factory;
22

3-
import static com.github.codeboyzhou.mcp.declarative.common.GuiceInjectorModule.VARIABLE_NAME_I18N_ENABLED;
3+
import static com.github.codeboyzhou.mcp.declarative.common.GuiceInjectorModule.INJECTED_VARIABLE_NAME_I18N_ENABLED;
44

55
import com.github.codeboyzhou.mcp.declarative.annotation.McpJsonSchemaDefinition;
66
import com.github.codeboyzhou.mcp.declarative.annotation.McpJsonSchemaDefinitionProperty;
@@ -40,7 +40,7 @@ public class McpServerToolFactory
4040

4141
@Inject
4242
protected McpServerToolFactory(
43-
Injector injector, @Named(VARIABLE_NAME_I18N_ENABLED) Boolean i18nEnabled) {
43+
Injector injector, @Named(INJECTED_VARIABLE_NAME_I18N_ENABLED) Boolean i18nEnabled) {
4444
super(injector, i18nEnabled);
4545
}
4646

0 commit comments

Comments
 (0)