Merge pull request #2266 from davidmillen50/reduce-fabricator-usage

Chore: reduce test suite run time by reducing test data fabrication

Author: olleolleolle

spec/features/admin/filtering_sponsors_list_spec.rb

@@ -6,14 +6,14 @@
   end
 
   describe 'when visiting the sponsors page' do
-    let!(:sponsors) { Fabricate.times(4, :sponsor_with_contacts) }
+    let!(:sponsors) { Fabricate.times(2, :sponsor_with_contacts) }
 
     before(:each) do
       visit admin_sponsors_path
     end
 
     scenario 'all the sponsors are displayed' do
-      expect(page).to have_css('.sponsor', count: 4)
+      expect(page).to have_css('.sponsor', count: 2)
     end
 
     describe 'when filtering by name' do

spec/features/admin/meeting_spec.rb

@@ -67,7 +67,7 @@
     let(:meeting) { Fabricate(:meeting) }
 
     scenario 'when format: :text' do
-      invitations = Fabricate.times(4, :attending_meeting_invitation, meeting: meeting)
+      invitations = Fabricate.times(2, :attending_meeting_invitation, meeting: meeting)
       visit attendees_emails_admin_meeting_path(meeting, format: :text)
 
       invitations.each do |invitation|

spec/features/admin/sponsor_spec.rb

@@ -34,7 +34,7 @@
       Fabricate(:workshop_sponsor, sponsor: sponsor)
       # Multiple works with the same sponsor and chapter
       chapter = Fabricate(:chapter)
-      5.times do
+      2.times do
         Fabricate(:workshop_sponsor, sponsor: sponsor2, workshop: Fabricate(:workshop_no_sponsor, chapter: chapter))
       end
 

spec/features/admin/workshops_spec.rb

@@ -10,7 +10,7 @@
 
   context '#views' do
     scenario 'list of all chapter workshops' do
-      workshops = Fabricate.times(5, :workshop, chapter: chapter)
+      workshops = Fabricate.times(2, :workshop, chapter: chapter)
       visit admin_chapter_workshops_path(chapter)
 
       workshops.each do |workshop|
@@ -189,7 +189,7 @@
 
     scenario 'viewing a text file with all attendee emails' do
       workshop = Fabricate(:workshop)
-      attendees = Fabricate.times(4, :attending_workshop_invitation, workshop: workshop)
+      attendees = Fabricate.times(2, :attending_workshop_invitation, workshop: workshop)
       attendees_emails = attendees.map(&:member).map(&:email)
       visit admin_workshop_attendees_emails_path(workshop, format: :text)
 
@@ -201,7 +201,7 @@
     context 'attendee names list' do
       scenario 'viewing a text file with all names' do
         workshop = Fabricate(:workshop)
-        attendees = Fabricate.times(4, :attending_workshop_invitation, workshop: workshop)
+        attendees = Fabricate.times(2, :attending_workshop_invitation, workshop: workshop)
         visit admin_workshop_attendees_checklist_path(workshop, format: :text)
         attendees.map(&:member).map(&:full_name).each do |name|
           expect(page).to have_content(name)

spec/features/chapter_spec.rb

@@ -61,7 +61,7 @@
 
     it 'renders the 6 most recent sponsors for the chapter' do
       chapter = Fabricate(:chapter)
-      workshops = 6.times.map do |n|
+      workshops = 2.times.map do |n|
         Fabricate(:workshop, chapter: chapter, date_and_time: Time.zone.now - n.weeks)
       end
 

spec/features/listing_coaches_spec.rb

@@ -8,31 +8,31 @@
   scenario 'I can see the top coaches by year' do
     latest_workshop = Fabricate(:workshop, date_and_time: Time.zone.now - 1.year)
     old_workshop = Fabricate(:workshop, date_and_time: Time.zone.now - 3.years)
-    invitations = 5.times { Fabricate(:attended_coach, workshop: latest_workshop) }
-    older_invitations = 15.times { Fabricate(:attended_coach, workshop: old_workshop) }
+    invitations = 2.times { Fabricate(:attended_coach, workshop: latest_workshop) }
+    older_invitations = 4.times { Fabricate(:attended_coach, workshop: old_workshop) }
 
     visit coaches_path(year: latest_workshop.date_and_time.year)
-    expect(page).to have_css(".coach", count: 5)
+    expect(page).to have_css(".coach", count: 2)
 
     visit coaches_path(year: old_workshop.date_and_time.year)
-    expect(page).to have_css(".coach", count: 15)
+    expect(page).to have_css(".coach", count: 4)
   end
 
   scenario 'I can navigate the top coaches by year' do
     current_workshop = Fabricate(:workshop, date_and_time: Time.zone.now)
     latest_workshop = Fabricate(:workshop, date_and_time: Time.zone.now - 1.year)
     old_workshop = Fabricate(:workshop, date_and_time: Time.zone.now - 3.years)
-    current_invitations = 10.times { Fabricate(:attended_coach, workshop: current_workshop) }
-    invitations = 7.times { Fabricate(:attended_coach, workshop: latest_workshop) }
-    older_invitations = 12.times { Fabricate(:attended_coach, workshop: old_workshop) }
+    current_invitations = 1.times { Fabricate(:attended_coach, workshop: current_workshop) }
+    invitations = 3.times { Fabricate(:attended_coach, workshop: latest_workshop) }
+    older_invitations = 2.times { Fabricate(:attended_coach, workshop: old_workshop) }
 
     visit coaches_path
-    expect(page).to have_css(".coach", count: 10)
+    expect(page).to have_css(".coach", count: 1)
 
     click_on latest_workshop.date_and_time.year.to_s
-    expect(page).to have_css(".coach", count: 7)
+    expect(page).to have_css(".coach", count: 3)
 
     click_on old_workshop.date_and_time.year.to_s
-    expect(page).to have_css(".coach", count: 12)
+    expect(page).to have_css(".coach", count: 2)
   end
 end

spec/features/listing_events_spec.rb

@@ -28,13 +28,13 @@
 
   context 'when there are more than the specified number of past events' do
     scenario 'I can only as many events allowed by the display limits' do
-      Fabricate.times(10, :event, date_and_time: 2.weeks.ago)
-      stub_const('EventsController::RECENT_EVENTS_DISPLAY_LIMIT', 10)
+      Fabricate.times(2, :event, date_and_time: 2.weeks.ago)
+      stub_const('EventsController::RECENT_EVENTS_DISPLAY_LIMIT', 2)
       Fabricate(:workshop, date_and_time: 3.weeks.ago)
 
       visit events_path
       within('*[data-test=past-events]') do
-        expect(page).to have_selector('*[data-test=event]', count: 10)
+        expect(page).to have_selector('*[data-test=event]', count: 2)
         expect(page).not_to have_content 'Workshop'
       end
     end

spec/features/member_portal_spec.rb

@@ -71,7 +71,7 @@
     end
 
     it 'can view the invitations they RSVPed to' do
-      invitations = 5.times.map { Fabricate(:attending_workshop_invitation, member: member) }
+      invitations = 2.times.map { Fabricate(:attending_workshop_invitation, member: member) }
       visit invitations_path
 
       expect(page).to have_content('Invitations')

spec/features/visiting_homepage_spec.rb

@@ -1,6 +1,6 @@
 RSpec.feature 'when visiting the homepage', type: :feature do
   let!(:next_workshop) { Fabricate(:workshop) }
-  let!(:events) { Fabricate.times(8, :event) }
+  let!(:events) { Fabricate.times(3, :event) }
 
   before(:each) do
     visit root_path
@@ -27,8 +27,8 @@
   end
 
   scenario 'I can only view active chapters' do
-    inactive_chapters = Fabricate.times(3, :chapter, active: false)
-    active_chapters = Fabricate.times(4, :chapter)
+    inactive_chapters = Fabricate.times(1, :chapter, active: false)
+    active_chapters = Fabricate.times(2, :chapter)
 
     visit root_path
 

spec/lib/tasks/delete_member_rake_spec.rb

@@ -15,10 +15,10 @@
   end
 
   it 'anonymises member information' do
-    invitations = Fabricate.times(4, :workshop_invitation, member: member)
+    invitations = Fabricate.times(2, :workshop_invitation, member: member)
     tokens = invitations.map(&:token)
 
-    subscriptions = Fabricate.times(3, :subscription, member: member)
+    subscriptions = Fabricate.times(1, :subscription, member: member)
 
     allow($stdin).to receive(:getch)