Merge pull request #2268 from olleolleolle/use-rspec-metadata-inferred

chore: infer RSpec metadata about "type" of test from file location

Author: matyikriszta

spec/controllers/admin/invitations_controller_spec.rb

@@ -1,5 +1,3 @@
-require "spec_helper"
-
 RSpec.describe Admin::InvitationsController, type: :controller do
   let(:invitation) { Fabricate(:student_workshop_invitation) }
   let(:workshop) { invitation.workshop }

spec/controllers/auth_services_controller_spec.rb

@@ -1,6 +1,4 @@
-require "spec_helper"
-
-RSpec.describe AuthServicesController, type: :controller do
+RSpec.describe AuthServicesController do
   describe "GET #new" do
     it "redirects when referer is missing" do
       expected_referer_path = nil

spec/controllers/members_controller_spec.rb

@@ -1,4 +1,4 @@
-RSpec.describe MembersController, type: :controller do
+RSpec.describe MembersController do
   describe "GET unsubscribe/#token" do
     it "redirects to the subscription path when token is valid" do
       member = Fabricate(:member)

spec/helpers/application_helper_spec.rb

@@ -1,4 +1,4 @@
-RSpec.describe ApplicationHelper, type: :helper do
+RSpec.describe ApplicationHelper do
   describe '#contact_email' do
     it "returns the workshop chapter's email" do
       workshop = Fabricate(:workshop)

spec/mailers/event_invitation_mailer_spec.rb

@@ -1,4 +1,4 @@
-RSpec.describe EventInvitationMailer, type: :mailer do
+RSpec.describe EventInvitationMailer do
   let(:email) { ActionMailer::Base.deliveries.last }
   let(:event) { Fabricate(:event, date_and_time: Time.zone.local(2017, 11, 12, 10, 0), name: 'Test event') }
   let(:coach_event) { Fabricate(:event, date_and_time: Time.zone.local(2017, 11, 12, 10, 0), name: 'Test event', audience: 'Coaches') }

spec/mailers/feedback_request_mailer_spec.rb

@@ -1,4 +1,4 @@
-RSpec.describe FeedbackRequestMailer, type: :mailer do
+RSpec.describe FeedbackRequestMailer do
   let(:email) { ActionMailer::Base.deliveries.last }
   let(:member) { Fabricate(:member) }
   let(:feedback_request) { Fabricate(:feedback_request, workshop: workshop, member: member) }

spec/mailers/meeting_invitation_mailer_spec.rb

@@ -1,4 +1,4 @@
-RSpec.describe MeetingInvitationMailer, type: :mailer do
+RSpec.describe MeetingInvitationMailer do
   let(:meeting) { Fabricate(:meeting) }
   let(:member) { Fabricate(:member) }
   let(:invitation) { Fabricate(:meeting_invitation, meeting: meeting, member: member) }

spec/mailers/member_mailer_spec.rb

@@ -1,4 +1,4 @@
-RSpec.describe MemberMailer, type: :mailer do
+RSpec.describe MemberMailer do
   let(:member) { Fabricate(:member) }
 
   describe 'welcome_student' do

spec/mailers/virtual_workshop_invitation_mailer_spec.rb

@@ -1,4 +1,4 @@
-RSpec.describe VirtualWorkshopInvitationMailer, type: :mailer do
+RSpec.describe VirtualWorkshopInvitationMailer do
   let(:email) { ActionMailer::Base.deliveries.last }
   let(:workshop) { Fabricate(:workshop) }
   let(:member) { Fabricate(:member) }

spec/mailers/workshop_invitation_mailer_spec.rb

@@ -1,4 +1,4 @@
-RSpec.describe WorkshopInvitationMailer, type: :mailer do
+RSpec.describe WorkshopInvitationMailer do
   let(:email) { ActionMailer::Base.deliveries.last }
   let(:workshop) { Fabricate(:workshop, title: 'HTML & CSS') }
   let(:member) { Fabricate(:member) }