Clean negative special needs and dietary restrictions (#202)

* fix: Clean negative special needs and dietary restrictions

* fix: Adds test for leading and trailing whitespace in negative checks

Co-authored-by: IlinDmitry <339966289@mail.ru>

Author: cbaudouinjr

app/models/questionnaire.rb

@@ -6,6 +6,8 @@ class Questionnaire < ApplicationRecord
 
   before_validation :consolidate_school_names
   before_validation :clean_for_non_rsvp
+  before_validation :clean_negative_special_needs
+  before_validation :clean_negative_dietary_restrictions
   after_create :queue_triggered_email_create
   after_update :queue_triggered_email_update
   after_save :update_school_questionnaire_count
@@ -226,6 +228,14 @@ def clean_for_non_rsvp
     end
   end
 
+  def clean_negative_special_needs
+    self.special_needs = nil if special_needs.present? && %w[none n/a non-applicable na nothing nil null no].include?(special_needs.strip.downcase)
+  end
+
+  def clean_negative_dietary_restrictions
+    self.dietary_restrictions = nil if dietary_restrictions.present? && %w[none n/a non-applicable na nothing nil null no].include?(dietary_restrictions.strip.downcase)
+  end
+
   def consolidate_school_names
     return if school.blank?
     duplicate = SchoolNameDuplicate.find_by(name: school.name)

test/models/questionnaire_test.rb

@@ -211,6 +211,130 @@ class QuestionnaireTest < ActiveSupport::TestCase
     end
   end
 
+  context "#clean_negative_special_needs" do
+    should "return nil if special_needs field is None" do
+      questionnaire = create(:questionnaire, special_needs: "NoNE")
+      assert_nil questionnaire.special_needs
+    end
+
+    should "return nil if special_needs field is n/a" do
+      questionnaire = create(:questionnaire, special_needs: "N/a")
+      assert_nil questionnaire.special_needs
+    end
+
+    should "return nil if special_needs fiels is non-applicable" do
+      questionnaire = create(:questionnaire, special_needs: "Non-applicable")
+      assert_nil questionnaire.special_needs
+    end
+
+    should "return nil if special_needs fiels is na" do
+      questionnaire = create(:questionnaire, special_needs: "na")
+      assert_nil questionnaire.special_needs
+    end
+
+    should "return nil if special_needs fiels is nothing" do
+      questionnaire = create(:questionnaire, special_needs: "nOthing")
+      assert_nil questionnaire.special_needs
+    end
+
+    should "return nil if special_needs fiels is nil" do
+      questionnaire = create(:questionnaire, special_needs: "Nil")
+      assert_nil questionnaire.special_needs
+    end
+
+    should "return nil if special_needs fiels is null" do
+      questionnaire = create(:questionnaire, special_needs: "nULL")
+      assert_nil questionnaire.special_needs
+    end
+
+    should "return nil if special_needs fiels is no" do
+      questionnaire = create(:questionnaire, special_needs: "no")
+      assert_nil questionnaire.special_needs
+    end
+
+    should "return nil if special_needs fiels is no (with spaces)" do
+      questionnaire = create(:questionnaire, special_needs: " no ")
+      assert_nil questionnaire.special_needs
+    end
+
+    should "return value if special_needs is none except for wheelchair" do
+      questionnaire = create(:questionnaire, special_needs: "None except for wheelchair")
+      assert_equal "None except for wheelchair", questionnaire.special_needs
+    end
+
+    should "return value if special_needs is no thank you" do
+      questionnaire = create(:questionnaire, special_needs: "no thank you")
+      assert_equal "no thank you", questionnaire.special_needs
+    end
+
+    should "return value if special_needs is need i need to sleep" do
+      questionnaire = create(:questionnaire, special_needs: "I need to sleep")
+      assert_equal "I need to sleep", questionnaire.special_needs
+    end
+  end
+
+  context "#clean_negative_dietary_restrictions" do
+    should "return nil if dietary_restrictions field is None" do
+      questionnaire = create(:questionnaire, dietary_restrictions: "NoNE")
+      assert_nil questionnaire.dietary_restrictions
+    end
+
+    should "return nil if dietary_restrictions field is n/a" do
+      questionnaire = create(:questionnaire, dietary_restrictions: "N/a")
+      assert_nil questionnaire.dietary_restrictions
+    end
+
+    should "return nil if dietary_restrictions field is non-applicable" do
+      questionnaire = create(:questionnaire, dietary_restrictions: "Non-applicable")
+      assert_nil questionnaire.dietary_restrictions
+    end
+
+    should "return nil if dietary_restrictions fiels is na" do
+      questionnaire = create(:questionnaire, dietary_restrictions: "na")
+      assert_nil questionnaire.dietary_restrictions
+    end
+
+    should "return nil if dietary_restrictions fiels is nothing" do
+      questionnaire = create(:questionnaire, dietary_restrictions: "nOthing")
+      assert_nil questionnaire.dietary_restrictions
+    end
+
+    should "return nil if dietary_restrictions fiels is nil" do
+      questionnaire = create(:questionnaire, dietary_restrictions: "Nil")
+      assert_nil questionnaire.dietary_restrictions
+    end
+
+    should "return nil if dietary_restrictions fiels is null" do
+      questionnaire = create(:questionnaire, dietary_restrictions: "nULL")
+      assert_nil questionnaire.dietary_restrictions
+    end
+
+    should "return nil if dietary_restrictions fiels is no" do
+      questionnaire = create(:questionnaire, dietary_restrictions: "no")
+      assert_nil questionnaire.dietary_restrictions
+    end
+
+    should "return nil if dietary_restrictions fiels is no (with spaces)" do
+      questionnaire = create(:questionnaire, dietary_restrictions: " no ")
+      assert_nil questionnaire.dietary_restrictions
+    end
+
+    should "return value if dietary_restrictions is nothing except for peanuts" do
+      questionnaire = create(:questionnaire, dietary_restrictions: "Nothing except for peanuts")
+      assert_equal "Nothing except for peanuts", questionnaire.dietary_restrictions
+    end
+
+    should "return value if dietary_restrictions is no thank you" do
+      questionnaire = create(:questionnaire, dietary_restrictions: "no thank you")
+      assert_equal "no thank you", questionnaire.dietary_restrictions
+    end
+
+    should "return value if dietary_restrictions is need i am a vegetarian" do
+      questionnaire = create(:questionnaire, dietary_restrictions: "I am a vegetarian")
+      assert_equal "I am a vegetarian", questionnaire.dietary_restrictions
+    end
+  end
+
   context "#minor?" do
     should "return true for 16 year old" do
       HackathonConfig['event_start_date'] = "2020-06-12"