Skip to content

Commit b8fbea4

Browse files
committed
Removed com.gorisse.thomas:android-view-lifecycle
1 parent 1cc23ae commit b8fbea4

File tree

3 files changed

+8
-18
lines changed

3 files changed

+8
-18
lines changed

sceneview/build.gradle

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,6 @@ dependencies {
124124
implementation "com.github.kittinunf.fuel:fuel:2.3.1"
125125
implementation "com.github.kittinunf.fuel:fuel-android:2.3.1"
126126
implementation "com.github.kittinunf.fuel:fuel-coroutines:2.3.1"
127-
128-
// Android View Lifecycle
129-
api "com.gorisse.thomas:android-view-lifecycle:1.0.5"
130127
}
131128

132129
apply plugin: "com.vanniktech.maven.publish"

sceneview/src/main/java/io/github/sceneview/SceneView.kt

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -270,12 +270,13 @@ open class SceneView @JvmOverloads constructor(
270270
selectedNodes = listOfNotNull(value)
271271
}
272272

273-
open val selectionVisualizer: (() -> Node)? = {
274-
ModelNode("sceneview/models/node_selector.glb").apply {
275-
isSelectable = false
276-
collisionShape = null
277-
}
278-
}
273+
open val selectionVisualizer: (() -> Node)? = null
274+
// {
275+
// ModelNode("sceneview/models/node_selector.glb").apply {
276+
// isSelectable = false
277+
// collisionShape = null
278+
// }
279+
// }
279280

280281
/**
281282
* ### Invoked when an frame is processed
@@ -315,7 +316,7 @@ open class SceneView @JvmOverloads constructor(
315316
get() = try {
316317
findFragment<Fragment>().requireActivity()
317318
} catch (e: Exception) {
318-
context.getActivity()!!
319+
context as? ComponentActivity
319320
}
320321

321322
private val displayHelper = DisplayHelper(context)

sceneview/src/main/java/io/github/sceneview/node/Node.kt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,6 @@ private const val defaultTouchSlop = 8
5252
open class Node(val engine: Engine) : NodeParent, TransformProvider,
5353
GestureDetector.OnGestureListener by GestureDetector.SimpleOnGestureListener() {
5454

55-
companion object {
56-
val DEFAULT_POSITION get() = Position(x = 0.0f, y = 0.0f, z = 0.0f)
57-
val DEFAULT_QUATERNION get() = Quaternion()
58-
val DEFAULT_ROTATION = DEFAULT_QUATERNION.toEulerAngles()
59-
val DEFAULT_SCALE get() = Scale(1.0f)
60-
}
61-
6255
/**
6356
* ### The scene that this node is part of, null if it isn't part of any scene
6457
*
@@ -490,7 +483,6 @@ open class Node(val engine: Engine) : NodeParent, TransformProvider,
490483
}
491484
}
492485
children.forEach { it.onFrame(frameTime) }
493-
// lastFrameTransform = transform
494486

495487
onFrame?.invoke(frameTime, this)
496488
}

0 commit comments

Comments
 (0)