Skip to content

Commit f5a95e8

Browse files
committed
Fix message and some specs
1 parent e079770 commit f5a95e8

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

app/services/namespaces/projects/flows/create_service.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ def create_node_function(node_function, t)
115115

116116
if reference_value.nil?
117117
t.rollback_and_return! ServiceResponse.error(
118-
message: 'Invalid reference value node id',
118+
message: 'Referenced node function not found',
119119
payload: :referenced_value_not_found
120120
)
121121
end

app/services/namespaces/projects/flows/validation/node_function/reference_value_validation_service.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def execute
2222
errors = []
2323

2424
unless reference_value.valid?
25-
errors += ValidationResult.error(:reference_value_invalid, reference_value.errors)
25+
errors << ValidationResult.error(:reference_value_invalid, reference_value.errors)
2626
end
2727

2828
# https://github.com/code0-tech/sagittarius/issues/508 Validate the usage and datatypes

spec/services/namespaces/projects/flows/validation/node_function/reference_value_validation_service_spec.rb

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,10 @@
4444
let(:data_type_identifier) do
4545
create(:data_type_identifier, data_type: create(:data_type, runtime: runtime), runtime: runtime)
4646
end
47-
let(:primary_level) { 0 }
48-
let(:secondary_level) { 0 }
49-
let(:tertiary_level) { nil }
5047
let(:reference_value) do
5148
create(:reference_value,
5249
node_function: create(:node_function))
5350
end
5451

55-
it { is_expected.to be_success }
52+
it { is_expected.to be_empty }
5653
end

0 commit comments

Comments
 (0)