Merge pull request #632 from code0-tech/add-name-field

Add name field for flow

Author: Taucher2003

app/graphql/mutations/namespaces/projects/flows/create.rb

@@ -27,7 +27,8 @@ def resolve(project_id:, flow:, **_params)
               namespace_project: project,
               flow_type: flow_type,
               starting_node: flow.starting_node,
-              flow_settings: flow.settings || []
+              flow_settings: flow.settings || [],
+              name: flow.name
             ).execute.to_mutation_response(success_key: :flow)
           end
 

app/graphql/types/flow_type.rb

@@ -6,7 +6,8 @@ class FlowType < Types::BaseObject
 
     authorize :read_flow
 
-    # field :name, String, null: false does exist in pictor but not in grpc
+    field :name, String, null: false, description: 'Name of the flow'
+
     field :input_type, Types::DataTypeType,
           null: true,
           description: 'The input data type of the flow'

app/graphql/types/input/flow_input_type.rb

@@ -5,6 +5,8 @@ module Input
     class FlowInputType < Types::BaseInputObject
       description 'Input type for creating or updating a flow'
 
+      argument :name, String, required: true, description: 'The name of the flow'
+
       argument :settings, [Types::Input::FlowSettingInputType], required: false,
                                                                 description: 'The settings of the flow'
       argument :starting_node, Types::Input::NodeFunctionInputType, required: true,

app/models/flow.rb

@@ -9,6 +9,10 @@ class Flow < ApplicationRecord
 
   has_many :flow_settings, class_name: 'FlowSetting', inverse_of: :flow
 
+  validates :name, presence: true,
+                   allow_blank: false,
+                   uniqueness: { case_sensitive: false, scope: :project_id }
+
   def to_grpc
     Tucana::Shared::ValidationFlow.new(
       flow_id: id,

db/migrate/20250526124346_create_flows.rb

@@ -59,6 +59,10 @@ def change
 
       t.references :starting_node, null: false, foreign_key: { to_table: :node_functions, on_delete: :restrict }
 
+      t.text :name, null: false
+
+      t.index %i[name project_id], unique: true
+
       t.timestamps_with_timezone
     end
 

db/structure.sql

@@ -250,6 +250,7 @@ CREATE TABLE flows (
     input_type_id bigint,
     return_type_id bigint,
     starting_node_id bigint NOT NULL,
+    name text NOT NULL,
     created_at timestamp with time zone NOT NULL,
     updated_at timestamp with time zone NOT NULL
 );
@@ -1099,6 +1100,8 @@ CREATE INDEX index_flows_on_flow_type_id ON flows USING btree (flow_type_id);
 
 CREATE INDEX index_flows_on_input_type_id ON flows USING btree (input_type_id);
 
+CREATE UNIQUE INDEX index_flows_on_name_and_project_id ON flows USING btree (name, project_id);
+
 CREATE INDEX index_flows_on_project_id ON flows USING btree (project_id);
 
 CREATE INDEX index_flows_on_return_type_id ON flows USING btree (return_type_id);

docs/graphql/input_object/flowinput.md

@@ -8,6 +8,7 @@ Input type for creating or updating a flow
 
 | Name | Type | Description |
 |------|------|-------------|
+| `name` | [`String!`](../scalar/string.md) | The name of the flow |
 | `settings` | [`[FlowSettingInput!]`](../input_object/flowsettinginput.md) | The settings of the flow |
 | `startingNode` | [`NodeFunctionInput!`](../input_object/nodefunctioninput.md) | The starting node of the flow |
 | `type` | [`FlowTypeID!`](../scalar/flowtypeid.md) | The identifier of the flow type |

docs/graphql/object/flow.md

@@ -11,6 +11,7 @@ Represents a flow
 | `createdAt` | [`Time!`](../scalar/time.md) | Time when this Flow was created |
 | `id` | [`FlowID!`](../scalar/flowid.md) | Global ID of this Flow |
 | `inputType` | [`DataType`](../object/datatype.md) | The input data type of the flow |
+| `name` | [`String!`](../scalar/string.md) | Name of the flow |
 | `nodes` | [`NodeFunctionConnection!`](../object/nodefunctionconnection.md) | Nodes of the flow |
 | `returnType` | [`DataType`](../object/datatype.md) | The return data type of the flow |
 | `settings` | [`FlowSettingConnection!`](../object/flowsettingconnection.md) | The settings of the flow |

spec/factories/flows.rb

@@ -1,12 +1,15 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
+  sequence(:flow_name) { |n| "Flow#{n}" }
+
   factory :flow do
     project factory: :namespace_project
     flow_type
     starting_node factory: :node_function
     flow_settings { [] }
     input_type { nil }
     return_type { nil }
+    name { generate(:flow_name) }
   end
 end

spec/models/flow_spec.rb

@@ -15,6 +15,11 @@
     it { is_expected.to have_many(:flow_settings) }
   end
 
+  describe 'validations' do
+    it { is_expected.to validate_presence_of(:name) }
+    it { is_expected.to validate_uniqueness_of(:name).case_insensitive.scoped_to(:project_id) }
+  end
+
   describe '#to_grpc' do
     let(:flow) do
       create(