ref: cargo clippy

Author: raphael-goetz

crates/cli/src/analyser/flow_type.rs

@@ -36,8 +36,8 @@ impl Analyser {
             ));
         }
 
-        if let Some(identifier) = &flow.input_type_identifier {
-            if !self.data_type_identifier_exists(identifier, None) {
+        if let Some(identifier) = &flow.input_type_identifier
+            && !self.data_type_identifier_exists(identifier, None) {
                 self.reporter.add(Diagnose::new(
                     name.clone(),
                     original.clone(),
@@ -46,9 +46,8 @@ impl Analyser {
                     },
                 ));
             }
-        }
-        if let Some(identifier) = &flow.return_type_identifier {
-            if !self.data_type_identifier_exists(identifier, None) {
+        if let Some(identifier) = &flow.return_type_identifier
+            && !self.data_type_identifier_exists(identifier, None) {
                 self.reporter.add(Diagnose::new(
                     name.clone(),
                     original.clone(),
@@ -57,7 +56,6 @@ impl Analyser {
                     },
                 ));
             }
-        }
 
         for setting in &flow.settings {
             if setting.name.is_empty() {

crates/cli/src/command/search.rs

@@ -35,7 +35,7 @@ fn search_and_display_definitions(search_name: &str, parser: &Parser) {
                         let mut index = 0;
                         for line in json.lines() {
                             index += 1;
-                            println!("{} {}", format!("{index}:"), line.bright_cyan());
+                            println!("{}: {}", index, line.bright_cyan());
                         }
                     }
                     Err(_) => println!("{}", "Error serializing FlowType".red()),
@@ -57,7 +57,7 @@ fn search_and_display_definitions(search_name: &str, parser: &Parser) {
                         let mut index = 0;
                         for line in json.lines() {
                             index += 1;
-                            println!("{} {}", format!("{index}:"), line.bright_cyan());
+                            println!("{}: {}", index, line.bright_cyan());
                         }
                     }
                     Err(_) => println!("{}", "Error serializing DataType".red()),
@@ -79,7 +79,7 @@ fn search_and_display_definitions(search_name: &str, parser: &Parser) {
                         let mut index = 0;
                         for line in json.lines() {
                             index += 1;
-                            println!("{} {}", format!("{index}:"), line.bright_cyan());
+                            println!("{}: {}", index, line.bright_cyan());
                         }
                     }
                     Err(_) => println!("{}", "Error serializing RuntimeFunction".red()),
@@ -89,10 +89,7 @@ fn search_and_display_definitions(search_name: &str, parser: &Parser) {
     }
 
     if !found_any {
-        println!(
-            "{}",
-            format!("\n{}: {}", "error".red(), "Found no matching definition(s)")
-        );
+        println!("\n{}: Found no matching definition(s)", "error".red(),);
     } else {
         success(format!("Found {total_matches} matching definition(s)"))
     }

crates/cli/src/formatter.rs

@@ -46,6 +46,6 @@ where
     Table::new(iter).with(Style::rounded()).to_string()
 }
 
-fn print_path(path: &String) -> String {
+fn print_path(path: &str) -> String {
     format!("\n --> {}", &path.underline()).blue().to_string()
 }

crates/cli/src/table.rs

@@ -76,7 +76,7 @@ pub fn feature_table(
     (flow_type_rows, data_type_rows, runtime_function_rows)
 }
 
-pub fn summary_table(features: &Vec<Feature>) -> Vec<FeatureSummaryRow> {
+pub fn summary_table(features: &[Feature]) -> Vec<FeatureSummaryRow> {
     features
         .iter()
         .map(|feature| FeatureSummaryRow {