ref: applied clippy changes

Author: raphael-goetz

cli/src/main.rs

@@ -3,7 +3,6 @@ use clap::{Parser as ClapParser, Subcommand};
 use colored::*;
 use notify::{Event, EventKind, RecursiveMode, Watcher, recommended_watcher};
 use reader::parser::Parser;
-use serde_json;
 use std::sync::mpsc::channel;
 
 mod table;
@@ -82,14 +81,14 @@ fn main() {
                 let mut features_to_report = Vec::new();
                 for feature in &parser.features {
                     if feature.name == feature_name {
-                        feature_table(&feature);
+                        feature_table(feature);
                         features_to_report.push(feature.clone());
                     }
                 }
                 summary_table(&features_to_report);
             } else {
                 for feature in &parser.features {
-                    feature_table(&feature);
+                    feature_table(feature);
                 }
                 summary_table(&parser.features);
             }

cli/src/table.rs

@@ -290,7 +290,7 @@ pub fn error_table(features: &Vec<Feature>) {
     }
 }
 
-pub fn summary_table(features: &Vec<Feature>) {
+pub fn summary_table(features: &[Feature]) {
     println!(
         "\n{}",
         "╔══════════════════════════════════════════════════════════════════════════════╗"

reader/rust/src/parser.rs

@@ -37,10 +37,7 @@ impl Feature {
 
 impl Parser {
     pub fn from_path(path: &str) -> Option<Self> {
-        let reader = match Reader::from_path(path) {
-            Some(reader) => reader,
-            None => return None,
-        };
+        let reader = Reader::from_path(path)?;
 
         Some(Self::from_reader(reader))
     }
@@ -77,9 +74,9 @@ impl Parser {
 
                 // Skip whitespace and find the opening quote
                 let trimmed = after_colon.trim_start();
-                if trimmed.starts_with('"') {
+                if let Some(stripped) = trimmed.strip_prefix('"') {
                     // Find the closing quote
-                    if let Some(end_quote) = trimmed[1..].find('"') {
+                    if let Some(end_quote) = stripped.find('"') {
                         return trimmed[1..end_quote + 1].to_string();
                     }
                 }

reader/rust/src/reader.rs

@@ -72,8 +72,8 @@ impl Meta {
         }
 
         Ok(Meta {
-            name: name,
-            r#type: r#type,
+            name,
+            r#type,
             data: code_snippets,
         })
     }
@@ -180,9 +180,8 @@ impl Reader {
 }
 
 fn get_file_name(entry: &DirEntry) -> Option<String> {
-    if let Some(file_name) = entry.file_name().to_str() {
-        Some(file_name.to_string())
-    } else {
-        None
-    }
+    entry
+        .file_name()
+        .to_str()
+        .map(|file_name| file_name.to_string())
 }