fix(ci,core,nx-plugin,create-cli): prevent duplicate process logs

Author: matejchalk

packages/ci/src/lib/cli/commands/collect.ts

@@ -3,7 +3,7 @@ import { executeProcess } from '@code-pushup/utils';
 import type { CommandContext } from '../context.js';
 
 export async function runCollect(
-  { bin, config, directory, observer }: CommandContext,
+  { bin, config, directory }: CommandContext,
   { hasFormats }: { hasFormats: boolean },
 ): Promise<void> {
   await executeProcess({
@@ -15,6 +15,5 @@ export async function runCollect(
         : DEFAULT_PERSIST_FORMAT.map(format => `--persist.format=${format}`)),
     ],
     cwd: directory,
-    observer,
   });
 }

packages/ci/src/lib/cli/commands/compare.ts

@@ -3,7 +3,7 @@ import { executeProcess } from '@code-pushup/utils';
 import type { CommandContext } from '../context.js';
 
 export async function runCompare(
-  { bin, config, directory, observer }: CommandContext,
+  { bin, config, directory }: CommandContext,
   { hasFormats }: { hasFormats: boolean },
 ): Promise<void> {
   await executeProcess({
@@ -16,6 +16,5 @@ export async function runCompare(
         : DEFAULT_PERSIST_FORMAT.map(format => `--persist.format=${format}`)),
     ],
     cwd: directory,
-    observer,
   });
 }

packages/ci/src/lib/cli/commands/merge-diffs.ts

@@ -8,7 +8,7 @@ import type { CommandContext } from '../context.js';
 
 export async function runMergeDiffs(
   files: string[],
-  { bin, config, directory, observer }: CommandContext,
+  { bin, config, directory }: CommandContext,
 ): Promise<string> {
   const outputDir = path.join(directory, DEFAULT_PERSIST_OUTPUT_DIR);
   const filename = `merged-${DEFAULT_PERSIST_FILENAME}`;
@@ -23,7 +23,6 @@ export async function runMergeDiffs(
       `--persist.filename=${filename}`,
     ],
     cwd: directory,
-    observer,
   });
 
   return path.join(outputDir, `${filename}-diff.md`);

packages/ci/src/lib/cli/commands/print-config.ts

@@ -12,7 +12,6 @@ export async function runPrintConfig({
   config,
   directory,
   project,
-  observer,
 }: CommandContext): Promise<unknown> {
   // unique file name per project so command can be run in parallel
   const outputFile = ['code-pushup', 'config', project, 'json']
@@ -33,7 +32,6 @@ export async function runPrintConfig({
       `--output=${outputPath}`,
     ],
     cwd: directory,
-    observer,
   });
 
   try {

packages/ci/src/lib/cli/context.ts

@@ -1,22 +1,18 @@
-import type { ProcessObserver } from '@code-pushup/utils';
-import { createExecutionObserver } from '../create-execution-observer.js';
 import type { Settings } from '../models.js';
 import type { ProjectConfig } from '../monorepo/index.js';
 
 export type CommandContext = Pick<Settings, 'bin' | 'config' | 'directory'> & {
   project?: string;
-  observer?: ProcessObserver;
 };
 
 export function createCommandContext(
-  { config, bin, directory, silent }: Settings,
+  { config, bin, directory }: Settings,
   project: ProjectConfig | null | undefined,
 ): CommandContext {
   return {
     bin: project?.bin ?? bin,
     directory: project?.directory ?? directory,
     config,
     ...(project?.name && { project: project.name }),
-    observer: createExecutionObserver({ silent }),
   };
 }

packages/ci/src/lib/cli/context.unit.test.ts

@@ -2,37 +2,29 @@ import { expect } from 'vitest';
 import { type CommandContext, createCommandContext } from './context.js';
 
 describe('createCommandContext', () => {
-  const expectedObserver = expect.objectContaining({
-    onStderr: expect.any(Function),
-    onStdout: expect.any(Function),
-  });
-
   it('should pick CLI-related settings in standalone mode', () => {
     expect(
       createCommandContext(
         {
           bin: 'npx --no-install code-pushup',
           config: null,
-          debug: false,
           detectNewIssues: true,
           directory: '/test',
-          logger: console,
           monorepo: false,
           parallel: false,
           nxProjectsFilter: '--with-target={task}',
           projects: null,
-          silent: false,
           task: 'code-pushup',
           skipComment: false,
           configPatterns: null,
+          searchCommits: false,
         },
         null,
       ),
     ).toStrictEqual<CommandContext>({
       bin: 'npx --no-install code-pushup',
       directory: '/test',
       config: null,
-      observer: expectedObserver,
     });
   });
 
@@ -42,18 +34,16 @@ describe('createCommandContext', () => {
         {
           bin: 'npx --no-install code-pushup',
           config: null,
-          debug: false,
           detectNewIssues: true,
           directory: '/test',
-          logger: console,
           monorepo: false,
           parallel: false,
           nxProjectsFilter: '--with-target={task}',
           projects: null,
-          silent: false,
           task: 'code-pushup',
           skipComment: false,
           configPatterns: null,
+          searchCommits: false,
         },
         {
           name: 'ui',
@@ -66,7 +56,6 @@ describe('createCommandContext', () => {
       directory: '/test/ui',
       config: null,
       project: 'ui',
-      observer: expectedObserver,
     });
   });
 });

packages/ci/src/lib/create-execution-observer.int.test.ts

@@ -19,14 +19,13 @@ export const nxHandler: MonorepoToolHandler = {
           command: 'npx',
           args: ['nx', 'report'],
           cwd: options.cwd,
-          observer: options.observer,
           ignoreExitCode: true,
         })
       ).code === 0
     );
   },
 
-  async listProjects({ cwd, task, nxProjectsFilter, observer }) {
+  async listProjects({ cwd, task, nxProjectsFilter }) {
     const { stdout } = await executeProcess({
       command: 'npx',
       args: [
@@ -37,7 +36,6 @@ export const nxHandler: MonorepoToolHandler = {
         '--json',
       ],
       cwd,
-      observer,
     });
     const projects = parseProjects(stdout);
     return projects.toSorted().map(project => ({