Skip to content

Commit 314ebed

Browse files
committed
refactor: rename chrome-path.setup.ts to chrome-path.mock.ts
1 parent dcf5665 commit 314ebed

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

packages/plugin-lighthouse/CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ To test lighthouse properly we work with a predefined testing setup.
1515

1616
On some OS there could be a problem finding the path to Chrome.
1717

18-
We try to detect it automatically in the [`chrome-path.setup.ts` script](../../testing/test-setup/src/lib/chrome-path.setup.ts).
18+
We try to detect it automatically in the [`chrome-path.mock.ts` script](../../testing/test-setup/src/lib/chrome-path.mock.ts).
1919
There we use `getChromePath` and have `chromium` installed as NPM package, so detecting the path should not cause any problem.
2020

2121
However, if no chrome path is detected automatically the error looks like this:
@@ -46,7 +46,7 @@ In the CI you can set a static path if needed over the env variable like this:
4646
# ...
4747
```
4848

49-
We consider this path in our `beforeAll` hook in a [`chrome-path.setup.ts` script](../../testing/test-setup/src/lib/chrome-path.setup.ts).
49+
We consider this path in our `beforeAll` hook in a [`chrome-path.mock.ts` script](../../testing/test-setup/src/lib/chrome-path.mock.ts).
5050

5151
### Testing chrome flags
5252

packages/plugin-lighthouse/vite.config.integration.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export default defineConfig({
2424
setupFiles: [
2525
'../../testing/test-setup/src/lib/cliui.mock.ts',
2626
'../../testing/test-setup/src/lib/reset.mocks.ts',
27-
'../../testing/test-setup/src/lib/chrome-path.setup.ts',
27+
'../../testing/test-setup/src/lib/chrome-path.mock.ts',
2828
],
2929
},
3030
});

packages/plugin-typescript/vite.config.integration.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export default defineConfig({
2424
setupFiles: [
2525
'../../testing/test-setup/src/lib/cliui.mock.ts',
2626
'../../testing/test-setup/src/lib/reset.mocks.ts',
27-
'../../testing/test-setup/src/lib/chrome-path.setup.ts',
27+
'../../testing/test-setup/src/lib/chrome-path.mock.ts',
2828
],
2929
},
3030
});

0 commit comments

Comments
 (0)