feat(plugin-coverage): replace @poppinss/cliui with new logger

Author: matejchalk

packages/plugin-coverage/package.json

@@ -36,7 +36,6 @@
   "dependencies": {
     "@code-pushup/models": "0.85.0",
     "@code-pushup/utils": "0.85.0",
-    "ansis": "^3.3.0",
     "parse-lcov": "^1.0.4",
     "yargs": "^17.7.2",
     "zod": "^4.0.5"

packages/plugin-coverage/src/lib/nx/coverage-paths.ts

@@ -6,9 +6,8 @@ import type {
 } from '@nx/devkit';
 import type { JestExecutorOptions } from '@nx/jest/src/executors/jest/schema';
 import type { VitestExecutorOptions } from '@nx/vite/executors';
-import { bold } from 'ansis';
 import path from 'node:path';
-import { importModule, stringifyError, ui } from '@code-pushup/utils';
+import { importModule, logger, stringifyError } from '@code-pushup/utils';
 import type { CoverageResult } from '../config.js';
 
 /**
@@ -22,7 +21,7 @@ async function resolveCachedProjectGraph() {
   try {
     return readCachedProjectGraph();
   } catch (error) {
-    ui().logger.info(
+    logger.info(
       `Could not read cached project graph, falling back to async creation.
       ${stringifyError(error)}`,
     );
@@ -36,13 +35,8 @@ async function resolveCachedProjectGraph() {
  */
 export async function getNxCoveragePaths(
   targets: string[] = ['test'],
-  verbose?: boolean,
 ): Promise<CoverageResult[]> {
-  if (verbose) {
-    ui().logger.info(
-      bold('💡 Gathering coverage from the following nx projects:'),
-    );
-  }
+  logger.debug('💡 Gathering coverage from the following nx projects:');
 
   const { nodes } = await resolveCachedProjectGraph();
 
@@ -55,18 +49,14 @@ export async function getNxCoveragePaths(
       return await Promise.all(
         relevantNodes.map<Promise<CoverageResult>>(async ({ name, data }) => {
           const coveragePaths = await getCoveragePathsForTarget(data, target);
-          if (verbose) {
-            ui().logger.info(`- ${name}: ${target}`);
-          }
+          logger.debug(`- ${name}: ${target}`);
           return coveragePaths;
         }),
       );
     }),
   );
 
-  if (verbose) {
-    ui().logger.info('\n');
-  }
+  logger.debug('');
 
   return coverageResults.flat();
 }

packages/plugin-coverage/src/lib/runner/index.ts

@@ -1,16 +1,13 @@
-import { bold } from 'ansis';
 import { writeFile } from 'node:fs/promises';
 import path from 'node:path';
 import type { RunnerConfig, RunnerFilesPaths } from '@code-pushup/models';
 import {
-  ProcessError,
   createRunnerFiles,
   ensureDirectoryExists,
   executeProcess,
   filePathToCliArg,
   objectToCliArgs,
   readJsonFile,
-  ui,
 } from '@code-pushup/utils';
 import type { FinalCoveragePluginConfig } from '../config.js';
 import { lcovResultsToAuditOutputs } from './lcov/lcov-runner.js';
@@ -28,16 +25,6 @@ export async function executeRunner({
     try {
       await executeProcess({ command, args });
     } catch (error) {
-      if (error instanceof ProcessError) {
-        const loggingFn = continueOnCommandFail
-          ? ui().logger.warning.bind(ui().logger)
-          : ui().logger.error.bind(ui().logger);
-        loggingFn(bold('stdout from failed coverage tool process:'));
-        loggingFn(error.stdout);
-        loggingFn(bold('stderr from failed coverage tool process:'));
-        loggingFn(error.stderr);
-      }
-
       if (!continueOnCommandFail) {
         throw new Error(
           'Coverage plugin: Running coverage tool failed. Make sure all your provided tests are passing.',

packages/plugin-coverage/src/lib/runner/lcov/lcov-runner.ts

@@ -5,11 +5,11 @@ import {
   type FileCoverage,
   exists,
   getGitRoot,
+  logger,
   objectFromEntries,
   objectToEntries,
   readTextFile,
   toUnixNewlines,
-  ui,
 } from '@code-pushup/utils';
 import type { CoverageResult, CoverageType } from '../../config.js';
 import { mergeLcovResults } from './merge-lcov.js';
@@ -72,9 +72,7 @@ export async function parseLcovFiles(
           typeof result === 'string' ? result : result.resultsPath;
         const lcovFileContent = await readTextFile(resultsPath);
         if (lcovFileContent.trim() === '') {
-          ui().logger.warning(
-            `Coverage plugin: Empty lcov report file detected at ${resultsPath}.`,
-          );
+          logger.warn(`Empty lcov report file detected at ${resultsPath}.`);
         }
         const parsedRecords = parseLcov(toUnixNewlines(lcovFileContent));
         return parsedRecords.map(

packages/plugin-coverage/src/lib/runner/lcov/lcov-runner.unit.test.ts

@@ -1,7 +1,7 @@
 import { vol } from 'memfs';
 import path from 'node:path';
 import { beforeEach, describe, expect, it, vi } from 'vitest';
-import { getGitRoot, ui } from '@code-pushup/utils';
+import { getGitRoot, logger } from '@code-pushup/utils';
 import type { CoverageResult, CoverageType } from '../../config.js';
 import { lcovResultsToAuditOutputs, parseLcovFiles } from './lcov-runner.js';
 
@@ -144,9 +144,8 @@ end_of_record
       path.join('coverage', 'lcov.info'),
     ]);
 
-    expect(ui()).toHaveLogged(
-      'warn',
-      `Coverage plugin: Empty lcov report file detected at ${path.join(
+    expect(logger.warn).toHaveBeenCalledWith(
+      `Empty lcov report file detected at ${path.join(
         'coverage',
         'lcov.info',
       )}.`,