move folder create to the init function instead of startRecording

code-matt · code-matt · commit 755fa0070589 · 2018-11-03T13:20:53.000-04:00
diff --git a/ios/RNReactNativeReplaykit.h b/ios/RNReactNativeReplaykit.h
@@ -14,8 +14,6 @@
 @interface RNReactNativeReplaykit : NSObject <RCTBridgeModule>
 
 @property (strong, nonatomic) RPScreenRecorder *screenRecorder;
-@property (strong, nonatomic) AVAssetWriter *assetWriter; // TODO
-@property (strong, nonatomic) AVAssetWriterInput *assetWriterInput; // TODO
 @property (strong, nonatomic) RPPreviewViewController *previewViewController;
 @property (strong, nonatomic) ScreenRecordCoordinator *screenRecordCoordinator;
 
diff --git a/ios/RNReactNativeReplaykit.m b/ios/RNReactNativeReplaykit.m
@@ -17,11 +17,11 @@ - (dispatch_queue_t)methodQueue
 RCT_EXPORT_METHOD(initialize)
 {
     self.screenRecordCoordinator = [[ScreenRecordCoordinator alloc] init];
+    [ReplayFileUtil createReplaysFolder];
 }
 
 RCT_EXPORT_METHOD(startRecording:(RCTResponseSenderBlock)callback)
 {
-    [ReplayFileUtil createReplaysFolder];
     static NSString *letters = @"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789";
     NSMutableString *randomString = [NSMutableString stringWithCapacity: 15];
     for (int i=0; i<15; i++) {
diff --git a/ios/ScreenRecord/ScreenRecorder.swift b/ios/ScreenRecord/ScreenRecorder.swift
@@ -34,7 +34,7 @@ import AVKit
             videoInput  = AVAssetWriterInput (mediaType: AVMediaTypeVideo as String, outputSettings: videoOutputSettings)
             videoInput.expectsMediaDataInRealTime = true
             assetWriter.add(videoInput)
-            
+//            RPScreenRecorder.shared().
             RPScreenRecorder.shared().startCapture(handler: { (sample, bufferType, error) in
                 //                print(sample,bufferType,error)
                 
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-native-replaykit",
-  "version": "1.0.6",
+  "version": "1.0.7",
   "description": "A React Native module to access ReplayKit Screen Recording Framework on iOS",
   "main": "index.js",
   "license" : "MIT",

Original file line number	Diff line number	Diff line change
`@@ -17,11 +17,11 @@ - (dispatch_queue_t)methodQueue`
`17`	`17`	`RCT_EXPORT_METHOD(initialize)`
`18`	`18`	`{`
`19`	`19`	`self.screenRecordCoordinator = [[ScreenRecordCoordinator alloc] init];`
	`20`	`+ [ReplayFileUtil createReplaysFolder];`
`20`	`21`	`}`
`21`	`22`
`22`	`23`	`RCT_EXPORT_METHOD(startRecording:(RCTResponseSenderBlock)callback)`
`23`	`24`	`{`
`24`		`- [ReplayFileUtil createReplaysFolder];`
`25`	`25`	`static NSString *letters = @"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789";`
`26`	`26`	`NSMutableString *randomString = [NSMutableString stringWithCapacity: 15];`
`27`	`27`	`for (int i=0; i<15; i++) {`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "react-native-replaykit",`
`3`		`- "version": "1.0.6",`
	`3`	`+ "version": "1.0.7",`
`4`	`4`	`"description": "A React Native module to access ReplayKit Screen Recording Framework on iOS",`
`5`	`5`	`"main": "index.js",`
`6`	`6`	`"license" : "MIT",`