Feat:FixJSON/file-ProviderFileForNile #325
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nilejack
commented
Oct 15, 2024
nilejack
commented
- feat:adds lesson_07/conditionals-nilejackson
- feat: completedLesson09/HW
- feat: adds/NileJack/Lesson_09HW
- "feat:adds/JSON.file"
- Delete lesson_07/conditionals/src/lesson7.ts
- Revert "feat:adds lesson_07/conditionals-nilejackson"
This reverts commit 54d548d.
Contributor
Author
|
Build for lesson09 worked, but I was unable to get rid of this lesson_07.ts file after running the commands in Chelsea's comments. |
Contributor
git checkout 70dccf221599fa5e10a335f17faa3a77abfa3950 -- lesson_07/conditionals/src/lesson7.ts
git commit -am "chore: removes changes to lesson7" |
anthonydmays
requested changes
Oct 16, 2024
Contributor
anthonydmays
left a comment
anthonydmays
left a comment
There was a problem hiding this comment.
Can't submit with the lesson7.ts file change. Get that resolved and then I can get this in for you.
| return "nilejack"; | ||
| } | ||
|
|
||
| @SuppressWarnings("rawtypes") |
Contributor
There was a problem hiding this comment.
Don't need this, please remove.
Contributor
|
Also, keep working on providing better names for your pull requests. Take a look at the conventional commits article again and note other pull requests so that you are following the established standard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.