chore: refactors media collection class

Author: anthonydmays

lesson_10/libraries/src/models/media_collection.ts

@@ -13,29 +13,24 @@ export class MediaCollection {
   }
 
   search(criteria?: SearchCriteria): ReadonlySet<MediaItem> {
-    const items = [...this.items.values()];
-    if (!criteria) {
-      return new Set(items);
+    if (criteria?.title) {
+      return this.searchByTitle(criteria.title);
     }
-    const title = criteria.title;
-    if (title) {
-      return this.searchByTitle(title);
-    }
-    if (criteria.releaseYear) {
+    if (criteria?.releaseYear) {
       return this.searchByReleaseYear(criteria.releaseYear);
     }
-    if (criteria.type) {
+    if (criteria?.type) {
       return this.searchByType(criteria.type);
     }
-    if (criteria.creditName) {
+    if (criteria?.creditName) {
       return this.searchByCreditName(criteria.creditName);
     }
-    return new Set(items);
+    return new Set(this.getItems());
   }
 
   searchByTitle(title: string): ReadonlySet<MediaItem> {
     return new Set(
-      [...this.items.values()].filter((item) =>
+      this.getItems().filter((item) =>
         item
           .getTitle()
           .toLowerCase()
@@ -46,21 +41,17 @@ export class MediaCollection {
 
   searchByReleaseYear(releaseYear: number): ReadonlySet<MediaItem> {
     return new Set(
-      [...this.items.values()].filter(
-        (item) => item.getReleaseYear() === releaseYear,
-      ),
+      this.getItems().filter((item) => item.getReleaseYear() === releaseYear),
     );
   }
 
   searchByType(type: string): ReadonlySet<MediaItem> {
-    return new Set(
-      [...this.items.values()].filter((item) => item.getType() === type),
-    );
+    return new Set(this.getItems().filter((item) => item.getType() === type));
   }
 
   searchByCreditName(name: string): ReadonlySet<MediaItem> {
     return new Set(
-      [...this.items.values()].filter((item) =>
+      this.getItems().filter((item) =>
         item.getCredits().some((credit) =>
           credit
             .getName()
@@ -71,6 +62,10 @@ export class MediaCollection {
     );
   }
 
+  private getItems(): readonly MediaItem[] {
+    return [...this.items.values()];
+  }
+
   getInfo() {
     return {
       getItems: () => [...this.items] as readonly [string, MediaItem][],