Merge pull request #20 from codacy/fix-issues-with-no-lines

Fix exception when issues has no line

Author: rtfpessoa

circle.yml

@@ -3,20 +3,33 @@ machine:
     - echo 'DOCKER_OPTS="-s btrfs -e lxc -D --userland-proxy=false"' | sudo tee -a /etc/default/docker
     - sudo curl -L -o /usr/bin/docker 'https://s3-external-1.amazonaws.com/circle-downloads/docker-1.9.0-circleci-cp-workaround'
     - sudo chmod 0755 /usr/bin/docker
+    - mkdir -p $HOME/.sbt/.lib/0.13.13 && wget https://repo.typesafe.com/typesafe/ivy-releases/org.scala-sbt/sbt-launch/0.13.13/sbt-launch.jar -O $HOME/.sbt/.lib/0.13.13/sbt-launch.jar
+    - (cd $HOME; rm -f codacy-plugins-test; git clone https://github.com/codacy/codacy-plugins-test.git)
   java:
     version: oraclejdk8
   services:
     - docker
 
 dependencies:
   override:
-    - sbt "set version in Docker := \"latest\"" "set name := \"$CIRCLE_PROJECT_REPONAME\"" docker:publishLocal
+    - (cd $HOME/codacy-plugins-test && sbt compile)
+    - (cd $HOME/$CIRCLE_PROJECT_REPONAME && sbt "set version in Docker := \"latest\"" "set name := \"$CIRCLE_PROJECT_REPONAME\"" docker:publishLocal)
+  cache_directories:
+    - "~/.ivy2"
+    - "~/.m2"
+    - "~/.sbt"
+    - "~/codacy-plugins-test/target"
+    - "~/codacy-plugins-test/project/target"
+    - "~/codacy-plugins-test/project/project"
+    - "~/$CIRCLE_PROJECT_REPONAME/target"
+    - "~/$CIRCLE_PROJECT_REPONAME/project/target"
+    - "~/$CIRCLE_PROJECT_REPONAME/project/project"
 
 test:
   pre:
-    - git clone https://github.com/codacy/codacy-plugins-test.git
+    - (cd $HOME/codacy-plugins-test; git fetch --all; git reset --hard origin/master)
   override:
-    - (cd codacy-plugins-test; sbt "run-main codacy.plugins.DockerTest all $CIRCLE_PROJECT_REPONAME:latest")
+    - (cd $HOME/codacy-plugins-test && sbt -Dcodacy.tests.noremove=true -Dcodacy.tests.threads=8 "run-main codacy.plugins.DockerTest pattern $CIRCLE_PROJECT_REPONAME:latest")
 
 deployment:
   hub:
@@ -25,4 +38,4 @@ deployment:
       - docker login -e $DOCKER_EMAIL -u $DOCKER_USER -p $DOCKER_PASS
       - docker tag $CIRCLE_PROJECT_REPONAME codacy/$CIRCLE_PROJECT_REPONAME
       - docker tag $CIRCLE_PROJECT_REPONAME codacy/$CIRCLE_PROJECT_REPONAME:1.0.$CIRCLE_BUILD_NUM
-      - docker push codacy/$CIRCLE_PROJECT_REPONAME
+      - docker push codacy/$CIRCLE_PROJECT_REPONAME

src/main/scala/codacy/pylint/Pylint.scala

@@ -54,21 +54,25 @@ object Pylint extends Tool {
   private implicit lazy val writer = Json.reads[Issue]
 
   private def parseLine(line: String) = {
-    val LineRegex = """(.*?)###(.*?)###(.*?)###(.*?)""".r
+    val LineRegex = """(.*?)###(\d*?)###(.*?)###(.*?)""".r
+
+    def createIssue(filename: String, lineNumber: String, message: String, patternId: String) = {
+      // If the pylint returns no line put the issue in the first line
+      val issueLine = if (lineNumber.nonEmpty) lineNumber.toInt else 1
+      Issue(SourcePath(filename),
+        ResultMessage(message),
+        PatternId(patternId),
+        ResultLine(issueLine))
+    }
+
     line match {
       case LineRegex(filename, lineNumber, message, patternId) if message.contains("invalid syntax") =>
         val fileError = FileError(SourcePath(filename),
           Option(ErrorMessage(message)))
-        val issue = Issue(SourcePath(filename),
-          ResultMessage(message),
-          PatternId(patternId),
-          ResultLine(lineNumber.toInt))
+        val issue = createIssue(filename, lineNumber, message, patternId)
         Option(List(fileError, issue))
       case LineRegex(filename, lineNumber, message, patternId) =>
-        Option(List(Issue(SourcePath(filename),
-          ResultMessage(message),
-          PatternId(patternId),
-          ResultLine(lineNumber.toInt))))
+        Option(List(createIssue(filename, lineNumber, message, patternId)))
       case _ =>
         Option.empty
     }