CCPackageDownload will call delegate method if writing file fails.

Author: NickyWeber

UnitTests/CCPackageDownloadTests.m

@@ -111,7 +111,6 @@ - (void)stopLoading
 
 #pragma mark - test
 
-
 @interface CCPackageDownloadTests : XCTestCase <CCPackageDownloadDelegate>
 
 @property (nonatomic, strong) CCPackageDownload *download;
@@ -133,7 +132,7 @@ - (void)setUp
 
     [(AppController *)[UIApplication sharedApplication].delegate configureCocos2d];
     [[CCDirector sharedDirector] stopAnimation];
-    // Sping the runloop a bit otherwise nondeterministic exceptions are thrown in the CCScheduler.
+    // Spin the runloop a bit otherwise nondeterministic exceptions are thrown in the CCScheduler.
     [[NSRunLoop currentRunLoop] runMode:NSDefaultRunLoopMode beforeDate:[NSDate dateWithTimeInterval:0.2 sinceDate:[NSDate date]]];
 
     [NSURLProtocol registerClass:[CCPackageDownloadTestURLProtocol class]];
@@ -256,6 +255,16 @@ - (void)testDownloadWith404Response
     XCTAssertNotNil(_downloadError);
 }
 
+- (void)testDownloadFolderNotAccessible
+{
+    // Writing to root level is supposed to fail
+    [_download setValue:[NSURL fileURLWithPath:@"/test.zip"] forKey:NSStringFromSelector(@selector(localURL))];
+
+    [self startDownloadAndWaitForDelegateToReturn];
+
+    XCTAssertFalse(_downloadSuccessful);
+    XCTAssertNotNil(_downloadError);
+}
 
 #pragma mark - Helper
 

cocos2d/CCPackageDownload.m

@@ -168,8 +168,10 @@ - (void)startDownloadAskingDelegateIfToResume:(BOOL)askDelegate
         return;
     }
 
-    if (![self createFileHandle])
+    NSError *error;
+    if (![self createFileHandle:&error])
     {
+        [self connection:_connection didFailWithError:error];
         return;
     }
 
@@ -264,16 +266,15 @@ - (NSURLRequest *)createRequest
     return result;
 }
 
-- (BOOL)createFileHandle
+- (BOOL)createFileHandle:(NSError **)error
 {
-    NSError *error;
-    NSFileHandle *fileHandle = [NSFileHandle fileHandleForWritingToURL:[NSURL fileURLWithPath:_tempPath] error:&error];
+    NSFileHandle *fileHandle = [NSFileHandle fileHandleForWritingToURL:[NSURL fileURLWithPath:_tempPath] error:error];
     CCLOGINFO(@"[PACKAGE/DOWNLOAD][INFO] Opening/Creating file for download: %@", _tempPath);
 
     if (!fileHandle)
     {
         [[NSFileManager defaultManager] createFileAtPath:_tempPath contents:nil attributes:nil];
-        fileHandle = [NSFileHandle fileHandleForWritingToURL:[NSURL fileURLWithPath:_tempPath] error:&error];
+        fileHandle = [NSFileHandle fileHandleForWritingToURL:[NSURL fileURLWithPath:_tempPath] error:error];
     }
 
     if (!fileHandle)