Skip to content

Commit e9f08e4

Browse files
committed
logictest: skip 3 tests for SERIALIZABLE notice
These test cases are flaky, and it appears to do with how the notice gets buffered before sending to the client. This is being fixed on master, but since it's a non-test code change and the bug is very minor, we won't backport the fix to 25.4. Release note: None
1 parent 4837a85 commit e9f08e4

File tree

1 file changed

+18
-11
lines changed

1 file changed

+18
-11
lines changed

pkg/ccl/logictestccl/testdata/logic_test/read_committed

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -227,20 +227,27 @@ DROP TABLE supermarket
227227
----
228228
NOTICE: setting transaction isolation level to SERIALIZABLE due to schema change
229229

230-
query T noticetrace
231-
DROP USER testuser
232-
----
233-
NOTICE: setting transaction isolation level to SERIALIZABLE due to schema change
230+
# Skip test cases for user/role creation, removal, and inheritance, as they are
231+
# flaky. https://github.com/cockroachdb/cockroach/pull/157072 should help, but
232+
# we are not backporting that to the 25.4 branch.
234233

235-
query T noticetrace
236-
CREATE USER testuser
237-
----
238-
NOTICE: setting transaction isolation level to SERIALIZABLE due to schema change
234+
# query T noticetrace
235+
# DROP USER testuser
236+
# ----
237+
# NOTICE: setting transaction isolation level to SERIALIZABLE due to schema change
239238

240-
query T noticetrace
239+
# query T noticetrace
240+
# CREATE USER testuser
241+
# ----
242+
# NOTICE: setting transaction isolation level to SERIALIZABLE due to schema change
243+
244+
# query T noticetrace
245+
# GRANT admin TO testuser
246+
# ----
247+
# NOTICE: setting transaction isolation level to SERIALIZABLE due to schema change
248+
249+
statement ok
241250
GRANT admin TO testuser
242-
----
243-
NOTICE: setting transaction isolation level to SERIALIZABLE due to schema change
244251

245252
query T noticetrace
246253
GRANT SELECT ON foo TO testuser

0 commit comments

Comments
 (0)