Skip to content

Commit e3c856b

Browse files
craig[bot]rafiss
andcommitted
Merge #155796
155796: roachtest: restrict knex test to GCE only r=rafiss a=rafiss The knex test requires pre-built node-oracledb binaries which are not available for IBM cloud's s390x architecture. This was causing the test to fail during npm install with error "NJS-067: a pre-built node-oracledb binary was not found for linux s390x". Restrict the test to run only on GCE to avoid this dependency issue. Resolves: #155605 Release note: None 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
2 parents 8aa3669 + 9ba22f6 commit e3c856b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/cmd/roachtest/tests/knex.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,11 +129,11 @@ func registerKnex(r registry.Registry) {
129129
r.Add(registry.TestSpec{
130130
Name: "knex",
131131
Owner: registry.OwnerSQLFoundations,
132-
// Requires a pre-built node-oracledb binary for linux arm64.
132+
// Requires a pre-built node-oracledb binary for linux arm64 and s390x.
133133
Cluster: r.MakeClusterSpec(1, spec.Arch(spec.OnlyAMD64)),
134134
Leases: registry.MetamorphicLeases,
135135
NativeLibs: registry.LibGEOS,
136-
CompatibleClouds: registry.AllExceptAWS,
136+
CompatibleClouds: registry.OnlyGCE,
137137
Suites: registry.Suites(registry.Nightly, registry.ORM),
138138
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
139139
runKnex(ctx, t, c)

0 commit comments

Comments
 (0)