Skip to content

Commit c357e10

Browse files
committed
storage: add "fast" store compression profile
Epic: none Release note: None
1 parent 2f38ee2 commit c357e10

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

docs/generated/settings/settings-for-tenants.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,7 @@ storage.delete_compaction_excise.enabled boolean true set to false to direct Peb
408408
storage.ingestion.value_blocks.enabled boolean true set to true to enable writing of value blocks in ingestion sstables application
409409
storage.max_sync_duration duration 20s maximum duration for disk operations; any operations that take longer than this setting trigger a warning log entry or process crash system-visible
410410
storage.max_sync_duration.fatal.enabled boolean true if true, fatal the process when a disk operation exceeds storage.max_sync_duration application
411-
storage.sstable.compression_algorithm enumeration fastest determines the compression algorithm to use when compressing sstable data blocks for use in a Pebble store (balanced,good are experimental); [snappy = 1, zstd = 2, none = 3, minlz = 4, fastest = 5, balanced = 6, good = 7] system-visible
411+
storage.sstable.compression_algorithm enumeration fastest determines the compression algorithm to use for Pebble stores [snappy = 1, zstd = 2, none = 3, minlz = 4, fastest = 5, balanced = 6, good = 7, fast = 8] system-visible
412412
storage.sstable.compression_algorithm_backup_storage enumeration fastest determines the compression algorithm to use when compressing sstable data blocks for backup row data storage (fast,balanced,good are experimental); [snappy = 1, zstd = 2, none = 3, minlz = 4, fastest = 5, fast = 6, balanced = 7, good = 8] system-visible
413413
storage.sstable.compression_algorithm_backup_transport enumeration fastest determines the compression algorithm to use when compressing sstable data blocks for backup transport (fast,balanced,good are experimental); [snappy = 1, zstd = 2, none = 3, minlz = 4, fastest = 5, fast = 6, balanced = 7, good = 8] system-visible
414414
timeseries.storage.resolution_10s.ttl duration 240h0m0s the maximum age of time series data stored at the 10 second resolution. Data older than this is subject to rollup and deletion. system-visible

docs/generated/settings/settings.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@
364364
<tr><td><div id="setting-storage-ingestion-value-blocks-enabled" class="anchored"><code>storage.ingestion.value_blocks.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>set to true to enable writing of value blocks in ingestion sstables</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
365365
<tr><td><div id="setting-storage-max-sync-duration" class="anchored"><code>storage.max_sync_duration</code></div></td><td>duration</td><td><code>20s</code></td><td>maximum duration for disk operations; any operations that take longer than this setting trigger a warning log entry or process crash</td><td>Advanced/Self-hosted (read-write); Basic/Standard (read-only)</td></tr>
366366
<tr><td><div id="setting-storage-max-sync-duration-fatal-enabled" class="anchored"><code>storage.max_sync_duration.fatal.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>if true, fatal the process when a disk operation exceeds storage.max_sync_duration</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
367-
<tr><td><div id="setting-storage-sstable-compression-algorithm" class="anchored"><code>storage.sstable.compression_algorithm</code></div></td><td>enumeration</td><td><code>fastest</code></td><td>determines the compression algorithm to use when compressing sstable data blocks for use in a Pebble store (balanced,good are experimental); [snappy = 1, zstd = 2, none = 3, minlz = 4, fastest = 5, balanced = 6, good = 7]</td><td>Advanced/Self-hosted (read-write); Basic/Standard (read-only)</td></tr>
367+
<tr><td><div id="setting-storage-sstable-compression-algorithm" class="anchored"><code>storage.sstable.compression_algorithm</code></div></td><td>enumeration</td><td><code>fastest</code></td><td>determines the compression algorithm to use for Pebble stores [snappy = 1, zstd = 2, none = 3, minlz = 4, fastest = 5, balanced = 6, good = 7, fast = 8]</td><td>Advanced/Self-hosted (read-write); Basic/Standard (read-only)</td></tr>
368368
<tr><td><div id="setting-storage-sstable-compression-algorithm-backup-storage" class="anchored"><code>storage.sstable.compression_algorithm_backup_storage</code></div></td><td>enumeration</td><td><code>fastest</code></td><td>determines the compression algorithm to use when compressing sstable data blocks for backup row data storage (fast,balanced,good are experimental); [snappy = 1, zstd = 2, none = 3, minlz = 4, fastest = 5, fast = 6, balanced = 7, good = 8]</td><td>Advanced/Self-hosted (read-write); Basic/Standard (read-only)</td></tr>
369369
<tr><td><div id="setting-storage-sstable-compression-algorithm-backup-transport" class="anchored"><code>storage.sstable.compression_algorithm_backup_transport</code></div></td><td>enumeration</td><td><code>fastest</code></td><td>determines the compression algorithm to use when compressing sstable data blocks for backup transport (fast,balanced,good are experimental); [snappy = 1, zstd = 2, none = 3, minlz = 4, fastest = 5, fast = 6, balanced = 7, good = 8]</td><td>Advanced/Self-hosted (read-write); Basic/Standard (read-only)</td></tr>
370370
<tr><td><div id="setting-storage-unhealthy-write-duration" class="anchored"><code>storage.unhealthy_write_duration</code></div></td><td>duration</td><td><code>20s</code></td><td>duration for disk write operations, beyond which the disk will be reported as unhealthy for higher layer actions</td><td>Advanced/Self-Hosted</td></tr>

pkg/storage/pebble.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,9 @@ const (
283283

284284
// StoreCompressionGood uses pebble.DBCompressionGood.
285285
StoreCompressionGood StoreCompressionSetting = 7
286+
287+
// StoreCompressionFast uses pebble.DBCompressionFast.
288+
StoreCompressionFast StoreCompressionSetting = 8
286289
)
287290

288291
var storeCompressionSettingToString = map[StoreCompressionSetting]string{
@@ -291,6 +294,7 @@ var storeCompressionSettingToString = map[StoreCompressionSetting]string{
291294
StoreCompressionNone: "none",
292295
StoreCompressionZstd: "zstd",
293296

297+
StoreCompressionFast: "fast",
294298
StoreCompressionFastest: "fastest",
295299
StoreCompressionBalanced: "balanced",
296300
StoreCompressionGood: "good",
@@ -305,6 +309,7 @@ var storeCompressionSettings = map[StoreCompressionSetting]pebble.DBCompressionS
305309
StoreCompressionFastest: pebble.DBCompressionFastest,
306310
StoreCompressionBalanced: pebble.DBCompressionBalanced,
307311
StoreCompressionGood: pebble.DBCompressionGood,
312+
StoreCompressionFast: pebble.DBCompressionFast,
308313
}
309314

310315
// String implements fmt.Stringer for StoreCompressionSetting.
@@ -338,7 +343,7 @@ const compressionSettingClass = settings.SystemVisible
338343
var CompressionAlgorithmStorage = settings.RegisterEnumSetting[StoreCompressionSetting](
339344
compressionSettingClass,
340345
"storage.sstable.compression_algorithm",
341-
`determines the compression algorithm to use when compressing sstable data blocks for use in a Pebble store (balanced,good are experimental);`,
346+
`determines the compression algorithm to use for Pebble stores`,
342347
// TODO(radu,jackson): use a metamorphic constant.
343348
StoreCompressionFastest.String(),
344349
storeCompressionSettingToString,

0 commit comments

Comments
 (0)