Merge #155482 #155956

155482: *: fix lint errors and remove empty tests r=rail a=rickystewart

Many of these changes are fixes to lint failures that were found by the
recent upgrade to Go 1.25.

The others delete empty test packages that serve no purpose (we would
otherwise build, link, and run the test binaries, only to actually run
no tests).

Release note: None
Epic: None

155956: sql/inspect: skip indexes with virtual columns during INSPECT r=spilchen a=spilchen

INSPECT previously attempted to verify index consistency on indexes containing virtual columns, which would result in internal errors. This occurred because INSPECT relies on LEFT LOOKUP JOIN ... `@{FORCE_INDEX=[...]}` constructs, which require all participating columns to be stored. Virtual columns are not compatible with this constraint, leading to a parser rejection.

This change modifies the behavior of INSPECT to skip any index that has a key column over a virtual column, thereby avoiding the internal error. A follow-up task has been opened to add proper support for virtual columns in INSPECT.

Informs: #155676
Informs: #155483
Epic: CRDB-55075

Release note (bug fix): INSPECT no longer fails when checking index consistency on indexes with virtual key columns. Such indexes will now be skipped.

Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
Co-authored-by: Matt Spilchen <matt.spilchen@cockroachlabs.com>

Author: 3 people

pkg/BUILD.bazel

@@ -97,7 +97,6 @@ ALL_TESTS = [
     "//pkg/ccl/spanconfigccl/spanconfigsqltranslatorccl:spanconfigsqltranslatorccl_test",
     "//pkg/ccl/spanconfigccl/spanconfigsqlwatcherccl:spanconfigsqlwatcherccl_test",
     "//pkg/ccl/sqlitelogictestccl/tests/3node-tenant:3node-tenant_test",
-    "//pkg/ccl/sqlitelogictestccl:sqlitelogictestccl_test",
     "//pkg/ccl/sqlproxyccl/acl:acl_test",
     "//pkg/ccl/sqlproxyccl/balancer:balancer_test",
     "//pkg/ccl/sqlproxyccl/interceptor:interceptor_test",
@@ -120,7 +119,6 @@ ALL_TESTS = [
     "//pkg/cli/clisqlexec:clisqlexec_test",
     "//pkg/cli/clisqlshell:clisqlshell_test",
     "//pkg/cli/democluster:democluster_test",
-    "//pkg/cli/exit:exit_test",
     "//pkg/cli:cli_disallowed_imports_test",
     "//pkg/cli:cli_test",
     "//pkg/cloud/amazon:amazon_test",
@@ -213,7 +211,6 @@ ALL_TESTS = [
     "//pkg/jobs/jobsauth:jobsauth_test",
     "//pkg/jobs/jobspb:jobspb_test",
     "//pkg/jobs/jobsprofiler:jobsprofiler_test",
-    "//pkg/jobs/jobsprotectedts:jobsprotectedts_test",
     "//pkg/jobs:jobs_test",
     "//pkg/keys:keys_test",
     "//pkg/keyvisualizer/spanstatsconsumer:spanstatsconsumer_test",
@@ -390,9 +387,7 @@ ALL_TESTS = [
     "//pkg/spanconfig/spanconfigkvsubscriber:spanconfigkvsubscriber_test",
     "//pkg/spanconfig/spanconfigmanager:spanconfigmanager_test",
     "//pkg/spanconfig/spanconfigptsreader:spanconfigptsreader_test",
-    "//pkg/spanconfig/spanconfigreconciler:spanconfigreconciler_test",
     "//pkg/spanconfig/spanconfigreporter:spanconfigreporter_test",
-    "//pkg/spanconfig/spanconfigsqltranslator:spanconfigsqltranslator_test",
     "//pkg/spanconfig/spanconfigsqlwatcher:spanconfigsqlwatcher_test",
     "//pkg/spanconfig/spanconfigstore:spanconfigstore_test",
     "//pkg/spanconfig/spanconfigtestutils:spanconfigtestutils_test",
@@ -861,7 +856,6 @@ ALL_TESTS = [
     "//pkg/workload/workload_generator:workload_generator_test",
     "//pkg/workload/workloadimpl:workloadimpl_test",
     "//pkg/workload/workloadsql:workloadsql_test",
-    "//pkg/workload/ycsb:ycsb_test",
     "//pkg/workload:workload_test",
 ]
 
@@ -1050,7 +1044,6 @@ GO_TARGETS = [
     "//pkg/ccl/spanconfigccl/spanconfigsqlwatcherccl:spanconfigsqlwatcherccl_test",
     "//pkg/ccl/sqlitelogictestccl/tests/3node-tenant:3node-tenant_test",
     "//pkg/ccl/sqlitelogictestccl:sqlitelogictestccl",
-    "//pkg/ccl/sqlitelogictestccl:sqlitelogictestccl_test",
     "//pkg/ccl/sqlproxyccl/acl:acl",
     "//pkg/ccl/sqlproxyccl/acl:acl_test",
     "//pkg/ccl/sqlproxyccl/balancer:balancer",
@@ -1105,7 +1098,6 @@ GO_TARGETS = [
     "//pkg/cli/democluster:democluster",
     "//pkg/cli/democluster:democluster_test",
     "//pkg/cli/exit:exit",
-    "//pkg/cli/exit:exit_test",
     "//pkg/cli/syncbench:syncbench",
     "//pkg/cli:cli",
     "//pkg/cli:cli_test",
@@ -1435,7 +1427,6 @@ GO_TARGETS = [
     "//pkg/jobs/jobsprofiler:jobsprofiler",
     "//pkg/jobs/jobsprofiler:jobsprofiler_test",
     "//pkg/jobs/jobsprotectedts:jobsprotectedts",
-    "//pkg/jobs/jobsprotectedts:jobsprotectedts_test",
     "//pkg/jobs/jobstest:jobstest",
     "//pkg/jobs/metricspoller:metricspoller",
     "//pkg/jobs:jobs",
@@ -1862,12 +1853,10 @@ GO_TARGETS = [
     "//pkg/spanconfig/spanconfigptsreader:spanconfigptsreader",
     "//pkg/spanconfig/spanconfigptsreader:spanconfigptsreader_test",
     "//pkg/spanconfig/spanconfigreconciler:spanconfigreconciler",
-    "//pkg/spanconfig/spanconfigreconciler:spanconfigreconciler_test",
     "//pkg/spanconfig/spanconfigreporter:spanconfigreporter",
     "//pkg/spanconfig/spanconfigreporter:spanconfigreporter_test",
     "//pkg/spanconfig/spanconfigsplitter:spanconfigsplitter",
     "//pkg/spanconfig/spanconfigsqltranslator:spanconfigsqltranslator",
-    "//pkg/spanconfig/spanconfigsqltranslator:spanconfigsqltranslator_test",
     "//pkg/spanconfig/spanconfigsqlwatcher:spanconfigsqlwatcher",
     "//pkg/spanconfig/spanconfigsqlwatcher:spanconfigsqlwatcher_test",
     "//pkg/spanconfig/spanconfigstore:spanconfigstore",
@@ -2914,7 +2903,6 @@ GO_TARGETS = [
     "//pkg/workload/workloadsql:workloadsql",
     "//pkg/workload/workloadsql:workloadsql_test",
     "//pkg/workload/ycsb:ycsb",
-    "//pkg/workload/ycsb:ycsb_test",
     "//pkg/workload:workload",
     "//pkg/workload:workload_test",
 ]

pkg/ccl/changefeedccl/schema_registry.go

@@ -302,7 +302,7 @@ func gracefulClose(ctx context.Context, toClose io.ReadCloser) {
 	const respExtraReadLimit = 4096
 	_, _ = io.CopyN(io.Discard, toClose, respExtraReadLimit)
 	if err := toClose.Close(); err != nil {
-		log.Changefeed.VInfof(ctx, 2, "failure to close schema registry connection", err)
+		log.Changefeed.VInfof(ctx, 2, "failure to close schema registry connection: %+v", err)
 	}
 }
 

pkg/ccl/sqlitelogictestccl/BUILD.bazel

@@ -1,18 +1,8 @@
-load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
 
 go_library(
     name = "sqlitelogictestccl",
     srcs = ["doc.go"],
     importpath = "github.com/cockroachdb/cockroach/pkg/ccl/sqlitelogictestccl",
     visibility = ["//visibility:public"],
 )
-
-go_test(
-    name = "sqlitelogictestccl_test",
-    size = "small",
-    srcs = ["doc_test.go"],
-    data = [
-        "@com_github_cockroachdb_sqllogictest//:testfiles",
-    ],
-    embed = [":sqlitelogictestccl"],
-)

pkg/ccl/sqlitelogictestccl/doc_test.go

@@ -1,4 +1,4 @@
-load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
 
 go_library(
     name = "exit",
@@ -11,10 +11,3 @@ go_library(
     visibility = ["//visibility:public"],
     deps = ["@com_github_cockroachdb_redact//:redact"],
 )
-
-go_test(
-    name = "exit_test",
-    size = "small",
-    srcs = ["codes_test.go"],
-    embed = [":exit"],
-)

pkg/cli/exit/BUILD.bazel

@@ -689,7 +689,7 @@ The "status" command outputs the binary and PID for the specified nodes:
 			}
 			for _, status := range statuses {
 				if status.Err != nil {
-					config.Logger.Printf("  %2d: %s %s\n", status.NodeID, status.Err.Error())
+					config.Logger.Printf("  %2d: %s\n", status.NodeID, status.Err.Error())
 				} else if !status.Running {
 					// TODO(irfansharif): Surface the staged version here?
 					config.Logger.Printf("  %2d: not running\n", status.NodeID)

pkg/cli/exit/codes_test.go

@@ -344,7 +344,7 @@ func runMultiTenantFairness(
 	}
 
 	ok, maxLatencyDelta := floatsWithinPercentage(meanLatencies, failThreshold)
-	t.L().Printf("max-latency-delta=%d% mean-latency-per-tenant=%v\n", int(maxLatencyDelta*100), meanLatencies)
+	t.L().Printf("max-latency-delta=%d%% mean-latency-per-tenant=%v\n", int(maxLatencyDelta*100), meanLatencies)
 	if !ok {
 		// TODO(irfansharif): Same as above -- this is a weak assertion.
 		t.L().Printf("latency not within expectations: %f > %f %v", maxLatencyDelta, failThreshold, meanLatencies)

pkg/cmd/roachprod/cli/commands.go

@@ -350,9 +350,9 @@ func runAllocationBench(
 	}
 	samples := make([]*clusterstats.ClusterStatRun, spec.samples)
 
-	t.L().Printf("cpu(%) means: average of (max-min) node cpu utilization across intervals")
-	t.L().Printf("write(%) means: average of (max-min) write disk utilization across intervals")
-	t.L().Printf("cost(gb) means: GBs sent for rebalancing operations between initial and end")
+	t.L().Printf("%s", "cpu(%) means: average of (max-min) node cpu utilization across intervals")
+	t.L().Printf("%s", "write(%) means: average of (max-min) write disk utilization across intervals")
+	t.L().Printf("%s", "cost(gb) means: GBs sent for rebalancing operations between initial and end")
 
 	for i := 0; i < spec.samples; i++ {
 		statCollector, cleanupFunc := setupAllocationBench(ctx, t, c, spec)

pkg/cmd/roachtest/tests/admission_control_multitenant_fairness.go

@@ -268,7 +268,7 @@ func (bd *backupDriver) runWorkload(ctx context.Context) (func(), error) {
 
 // scheduleBackups begins the backup schedule.
 func (bd *backupDriver) scheduleBackups(ctx context.Context) {
-	bd.t.L().Printf("creating backup schedule", bd.sp.fixture.WorkloadWarehouses)
+	bd.t.L().Printf("creating backup schedule %d", bd.sp.fixture.WorkloadWarehouses)
 	conn := bd.c.Conn(ctx, bd.t.L(), 1)
 	defer conn.Close()
 	if bd.sp.fixture.CompactionThreshold > 0 {
@@ -565,7 +565,7 @@ func GetFixtureRegistry(ctx context.Context, t test.Test, cloud spec.Cloud) *blo
 	case spec.GCE, spec.Local:
 		account, err := vm.Providers["gce"].FindActiveAccount(t.L())
 		require.NoError(t, err)
-		t.L().Printf("using GCE account", account)
+		t.L().Printf("using GCE account %s", account)
 
 		uri = url.URL{
 			Scheme:   "gs",