sql/inspect: update package and function names after file move

Previously, inspect_job.go was in the pkg/sql package and exported
functions with "Inspect" prefixes (TriggerInspectJob,
InspectChecksForTable, etc.).

After moving the file to pkg/sql/inspect, this commit updates:
- Package declaration from `sql` to `inspect`
- Adds `sql` package import for types like ExecutorConfig and PlanHookState
- Renames functions to remove redundant "Inspect" prefix:
  - TriggerInspectJob -> TriggerJob
  - InspectChecksForTable -> ChecksForTable
  - InspectChecksForDatabase -> checksForDatabase (now unexported)
  - InspectChecksByIndexNames -> checksByIndexNames (now unexported)
- Updates all callers in inspect_plan.go and import_job.go

The "Inspect" prefix is redundant since the functions are now in the
inspect package. Functions only used internally are now unexported.

Release note: None

Epic: None

Author: spilchen

pkg/sql/importer/import_job.go

@@ -329,12 +329,12 @@ func (r *importResumer) Resume(ctx context.Context, execCtx interface{}) error {
 		}
 		tblDesc := tabledesc.NewBuilder(table.Desc).BuildImmutableTable()
 		if len(tblDesc.PublicNonPrimaryIndexes()) > 0 {
-			checks, err := inspect.InspectChecksForTable(ctx, nil /* p */, tblDesc)
+			checks, err := inspect.ChecksForTable(ctx, nil /* p */, tblDesc)
 			if err != nil {
 				return err
 			}
 
-			job, err := inspect.TriggerInspectJob(
+			job, err := inspect.TriggerJob(
 				ctx,
 				fmt.Sprintf("import-validation-%s", tblDesc.GetName()),
 				p.ExecCfg(),

pkg/sql/inspect/inspect_job_entry.go

@@ -25,8 +25,8 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/util/log"
 )
 
-// TriggerInspectJob starts an inspect job for the snapshot.
-func TriggerInspectJob(
+// TriggerJob starts an inspect job for the snapshot.
+func TriggerJob(
 	ctx context.Context,
 	jobRecordDescription string,
 	execCfg *sql.ExecutorConfig,
@@ -94,9 +94,9 @@ func TriggerInspectJob(
 	return job, nil
 }
 
-// InspectChecksForDatabase generates checks on every supported index on every
+// checksForDatabase generates checks on every supported index on every
 // table in the given database.
-func InspectChecksForDatabase(
+func checksForDatabase(
 	ctx context.Context, p sql.PlanHookState, db catalog.DatabaseDescriptor,
 ) ([]*jobspb.InspectDetails_Check, error) {
 	avoidLeased := false
@@ -115,7 +115,7 @@ func InspectChecksForDatabase(
 	checks := []*jobspb.InspectDetails_Check{}
 
 	if err := tables.ForEachDescriptor(func(desc catalog.Descriptor) error {
-		tableChecks, err := InspectChecksForTable(ctx, p, desc.(catalog.TableDescriptor))
+		tableChecks, err := ChecksForTable(ctx, p, desc.(catalog.TableDescriptor))
 		if err != nil {
 			return err
 		}
@@ -128,9 +128,9 @@ func InspectChecksForDatabase(
 	return checks, nil
 }
 
-// InspectChecksForTable generates checks on every supported index on the given
+// ChecksForTable generates checks on every supported index on the given
 // table.
-func InspectChecksForTable(
+func ChecksForTable(
 	ctx context.Context, p sql.PlanHookState, table catalog.TableDescriptor,
 ) ([]*jobspb.InspectDetails_Check, error) {
 	checks := []*jobspb.InspectDetails_Check{}
@@ -160,10 +160,10 @@ type indexKey struct {
 	descpb.IndexID
 }
 
-// InspectChecksByIndexNames generates checks for the specified index names.
+// checksByIndexNames generates checks for the specified index names.
 // If index names are not found or are not supported for inspection, an error is returned.
 // Index names are deduplicated.
-func InspectChecksByIndexNames(
+func checksByIndexNames(
 	ctx context.Context, p sql.PlanHookState, names tree.TableIndexNames,
 ) ([]*jobspb.InspectDetails_Check, error) {
 	checks := []*jobspb.InspectDetails_Check{}

pkg/sql/inspect/inspect_plan.go

@@ -109,13 +109,13 @@ func newInspectRun(
 		// No INDEX options or INDEX ALL specified - inspect all indexes.
 		switch stmt.Typ {
 		case tree.InspectTable:
-			checks, err := InspectChecksForTable(ctx, p, run.table)
+			checks, err := ChecksForTable(ctx, p, run.table)
 			if err != nil {
 				return inspectRun{}, err
 			}
 			run.checks = checks
 		case tree.InspectDatabase:
-			if checks, err := InspectChecksForDatabase(ctx, p, run.db); err != nil {
+			if checks, err := checksForDatabase(ctx, p, run.db); err != nil {
 				return inspectRun{}, err
 			} else {
 				run.checks = checks
@@ -152,7 +152,7 @@ func newInspectRun(
 			}
 		}
 
-		if checks, err := InspectChecksByIndexNames(ctx, p, run.namedIndexes); err != nil {
+		if checks, err := checksByIndexNames(ctx, p, run.namedIndexes); err != nil {
 			return inspectRun{}, err
 		} else {
 			run.checks = checks
@@ -236,7 +236,7 @@ func inspectPlanHook(
 		// the job record creation happens transactionally.
 		plannerTxn := p.InternalSQLTxn()
 
-		sj, err := sql.TriggerInspectJob(ctx, tree.AsString(stmt), p.ExecCfg(), plannerTxn, run.checks, run.asOfTimestamp)
+		sj, err := TriggerJob(ctx, tree.AsString(stmt), p.ExecCfg(), plannerTxn, run.checks, run.asOfTimestamp)
 		if err != nil {
 			return err
 		}