schemachanger: implement ALTER TABLE .. RENAME in declarative schema changer

This preserves all the validations and error handling from the legacy schema
changer.

Release note: None

Author: rafiss

pkg/ccl/changefeedccl/alter_changefeed_test.go

@@ -1273,7 +1273,8 @@ func TestAlterChangefeedAlterTableName(t *testing.T) {
 
 		expectResolvedTimestamp(t, testFeed)
 
-		waitForSchemaChange(t, sqlDB, `ALTER TABLE movr.users RENAME TO movr.riders`)
+		sqlDB.Exec(t, `ALTER TABLE movr.users RENAME TO movr.riders`)
+		sqlDB.CheckQueryResultsRetry(t, "SELECT count(*) FROM [SHOW TABLES FROM movr] WHERE table_name = 'riders'", [][]string{{"1"}})
 
 		var tsLogical string
 		sqlDB.QueryRow(t, `SELECT cluster_logical_timestamp()`).Scan(&tsLogical)

pkg/ccl/schemachangerccl/sctestbackupccl/backup_base_generated_test.go

@@ -244,8 +244,9 @@ USE defaultdb;
 			dscExpectedErr: `pq: cannot drop view v because other objects depend on it`,
 		},
 		{
-			stmt:        "ALTER TABLE t RENAME TO t_new",
-			expectedErr: `pq: cannot rename relation "t" because function "f" depends on it`,
+			stmt:           "ALTER TABLE t RENAME TO t_new",
+			expectedErr:    `pq: cannot rename relation "t" because function "f" depends on it`,
+			dscExpectedErr: `pq: cannot rename relation "defaultdb.public.t" because function "f" depends on it`,
 		},
 		{
 			stmt:        "ALTER TABLE t SET SCHEMA test_sc",

pkg/sql/drop_function_test.go

@@ -21,8 +21,16 @@ DROP SEQUENCE renamed_again_alter_test
 statement ok
 CREATE SEQUENCE foo
 
+statement error pgcode 42809 "foo" is not a view
+ALTER VIEW foo RENAME TO bar
+
+# The legacy schema changer was more strict about using ALTER TABLE to rename
+# a sequence. Since Postgres allows that, the declarative schema changer
+# supports it.
+onlyif config local-legacy-schema-changer local-mixed-25.2 local-mixed-25.3
 statement error pgcode 42809 "foo" is not a table
 ALTER TABLE foo RENAME TO bar
 
-statement error pgcode 42809 "foo" is not a view
-ALTER VIEW foo RENAME TO bar
+skipif config local-legacy-schema-changer local-mixed-25.2 local-mixed-25.3
+statement ok
+ALTER TABLE foo RENAME TO bar

pkg/sql/logictest/testdata/logic_test/rename_sequence

@@ -165,9 +165,14 @@ SELECT * FROM test.v2
 statement ok
 CREATE VIEW v3 AS SELECT count(*) FROM test.v AS v JOIN test.v2 AS v2 ON v.k > v2.c1
 
+# onlyif config local-legacy-schema-changer
 statement error cannot rename relation "test.public.v" because view "v3" depends on it
 ALTER VIEW test.v RENAME TO test.v3
 
+# skipif config local-legacy-schema-changer
+# statement error relation "test.public.v3" already exists
+# ALTER VIEW test.v RENAME TO test.v3
+
 statement error cannot rename relation "test.public.v2" because view "v3" depends on it
 ALTER VIEW test.v2 RENAME TO v4
 

pkg/sql/logictest/testdata/logic_test/rename_view

@@ -341,7 +341,7 @@ FROM
 WHERE
 	name = 'kv'
 
-statement error pgcode XX000 internal error: relation "kv" \(\d+\): column "k" invalid ID \(1\) >= next column ID \(1\)
+statement error pgcode XX000 internal error:.* relation "kv" \(\d+\): column "k" invalid ID \(1\) >= next column ID \(1\)
 ALTER TABLE kv RENAME TO kv
 
 statement ok

pkg/sql/logictest/testdata/logic_test/schema_repair

@@ -204,6 +204,11 @@ statement error pgcode 2BP01 pq: cannot rename column "a" because function "f_un
 ALTER TABLE t_twocol RENAME COLUMN a TO d;
 
 # TODO(#101934): Postgres allows table renaming when only referenced by UDFs.
+skipif config local-legacy-schema-changer local-mixed-25.2 local-mixed-25.3
+statement error pgcode 2BP01 pq: cannot rename relation "test.public.t_twocol" because function "f_unqualified_twocol" depends on it
+ALTER TABLE t_twocol RENAME TO t_twocol_prime;
+
+onlyif config local-legacy-schema-changer local-mixed-25.2 local-mixed-25.3
 statement error pgcode 2BP01 pq: cannot rename relation "t_twocol" because function "f_unqualified_twocol" depends on it
 ALTER TABLE t_twocol RENAME TO t_twocol_prime;
 

pkg/sql/logictest/testdata/logic_test/udf_star

@@ -4777,6 +4777,7 @@ func TestBlockedSchemaChange(t *testing.T) {
 	codec := s.ApplicationLayer().Codec()
 	sqlDB := sqlutils.MakeSQLRunner(db)
 
+	sqlDB.Exec(t, `SET CLUSTER SETTING sql.defaults.use_declarative_schema_changer = 'off'`)
 	sqlDB.Exec(t, `
 	  SET create_table_with_schema_locked=false;
 	  SET use_declarative_schema_changer='off';

pkg/sql/schema_changer_test.go

@@ -340,6 +340,10 @@ func (pb payloadBuilder) droppedSchemaObjects(b buildCtx) (ret []string) {
 func (pb payloadBuilder) build(b buildCtx) logpb.EventPayload {
 	const mutationID = 1
 	switch e := pb.Element().(type) {
+	case *scpb.Namespace:
+		if pb.maybePayload != nil {
+			return pb.maybePayload
+		}
 	case *scpb.Database:
 		if pb.TargetStatus == scpb.Status_PUBLIC {
 			return &eventpb.CreateDatabase{

pkg/sql/schemachanger/scbuild/event_log.go

@@ -46,6 +46,7 @@ go_library(
         "partition_helpers.go",
         "partition_zone_config.go",
         "process.go",
+        "rename_table.go",
         "statement_control.go",
         "table_zone_config.go",
         "truncate.go",