Merge #155536

155536: vecindex: enable vector indexing by default r=mw5h a=mw5h

While vector indexing was in tech preview, it was disabled by default. Now that we are transitioning this feature to general availability, it needs to be enabled by default.

Epic: CRDB-52151
Release note (sql change): Vector indexing is now enabled by default.

Co-authored-by: Matt White <matt.white@cockroachlabs.com>

Author: craig[bot]

docs/generated/settings/settings-for-tenants.txt

@@ -77,7 +77,7 @@ feature.infer_rbr_region_col_using_constraint.enabled	boolean	false	set to true
 feature.restore.enabled	boolean	true	set to true to enable restore, false to disable; default is true	application
 feature.schema_change.enabled	boolean	true	set to true to enable schema changes, false to disable; default is true	application
 feature.stats.enabled	boolean	true	set to true to enable CREATE STATISTICS/ANALYZE, false to disable; default is true	application
-feature.vector_index.enabled	boolean	false	set to true to enable vector indexes, false to disable; default is false	application
+feature.vector_index.enabled	boolean	true	set to true to enable vector indexes, false to disable; default is true	application
 jobs.retention_time	duration	336h0m0s	the amount of time for which records for completed jobs are retained	application
 kv.bulk_sst.target_size	byte size	16 MiB	target size for SSTs emitted from export requests; export requests (i.e. BACKUP) may buffer up to the sum of kv.bulk_sst.target_size and kv.bulk_sst.max_allowed_overage in memory	system-visible
 kv.closed_timestamp.follower_reads.enabled (alias: kv.closed_timestamp.follower_reads_enabled)	boolean	true	allow (all) replicas to serve consistent historical reads based on closed timestamp information	system-visible

docs/generated/settings/settings.html

@@ -82,7 +82,7 @@
 <tr><td><div id="setting-feature-restore-enabled" class="anchored"><code>feature.restore.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>set to true to enable restore, false to disable; default is true</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
 <tr><td><div id="setting-feature-schema-change-enabled" class="anchored"><code>feature.schema_change.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>set to true to enable schema changes, false to disable; default is true</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
 <tr><td><div id="setting-feature-stats-enabled" class="anchored"><code>feature.stats.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>set to true to enable CREATE STATISTICS/ANALYZE, false to disable; default is true</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
-<tr><td><div id="setting-feature-vector-index-enabled" class="anchored"><code>feature.vector_index.enabled</code></div></td><td>boolean</td><td><code>false</code></td><td>set to true to enable vector indexes, false to disable; default is false</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
+<tr><td><div id="setting-feature-vector-index-enabled" class="anchored"><code>feature.vector_index.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>set to true to enable vector indexes, false to disable; default is true</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
 <tr><td><div id="setting-jobs-retention-time" class="anchored"><code>jobs.retention_time</code></div></td><td>duration</td><td><code>336h0m0s</code></td><td>the amount of time for which records for completed jobs are retained</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
 <tr><td><div id="setting-kv-allocator-lease-rebalance-threshold" class="anchored"><code>kv.allocator.lease_rebalance_threshold</code></div></td><td>float</td><td><code>0.05</code></td><td>minimum fraction away from the mean a store&#39;s lease count can be before it is considered for lease-transfers</td><td>Advanced/Self-Hosted</td></tr>
 <tr><td><div id="setting-kv-allocator-load-based-lease-rebalancing-enabled" class="anchored"><code>kv.allocator.load_based_lease_rebalancing.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>set to enable rebalancing of range leases based on load and latency</td><td>Advanced/Self-Hosted</td></tr>

pkg/sql/backfill/backfill_test.go

@@ -52,9 +52,6 @@ func TestVectorColumnAndIndexBackfill(t *testing.T) {
 	defer srv.Stopper().Stop(ctx)
 	sqlDB := sqlutils.MakeSQLRunner(db)
 
-	// Enable vector indexes.
-	sqlDB.Exec(t, `SET CLUSTER SETTING feature.vector_index.enabled = true`)
-
 	// Create a table with a vector column
 	sqlDB.Exec(t, `
 		CREATE TABLE vectors (
@@ -119,9 +116,6 @@ func TestConcurrentOperationsDuringVectorIndexCreation(t *testing.T) {
 	defer srv.Stopper().Stop(ctx)
 	sqlDB := sqlutils.MakeSQLRunner(db)
 
-	// Enable vector indexes.
-	sqlDB.Exec(t, `SET CLUSTER SETTING feature.vector_index.enabled = true`)
-
 	// Create a table with a vector column
 	sqlDB.Exec(t, `
 		CREATE TABLE vectors (
@@ -204,9 +198,6 @@ func TestVectorIndexWithPrefixBackfill(t *testing.T) {
 	defer srv.Stopper().Stop(ctx)
 	sqlDB := sqlutils.MakeSQLRunner(db)
 
-	// Enable vector indexes.
-	sqlDB.Exec(t, `SET CLUSTER SETTING feature.vector_index.enabled = true`)
-
 	// Create a table with a vector column + a prefix column.
 	sqlDB.Exec(t, `
 		CREATE TABLE items (
@@ -276,9 +267,6 @@ func TestVectorIndexMergingDuringBackfill(t *testing.T) {
 	defer srv.Stopper().Stop(ctx)
 	sqlDB := sqlutils.MakeSQLRunner(db)
 
-	// Enable vector indexes.
-	sqlDB.Exec(t, `SET CLUSTER SETTING feature.vector_index.enabled = true`)
-
 	// Enable deterministic vector index fixups for consistent testing.
 	sqlDB.Exec(t, `SET CLUSTER SETTING sql.vecindex.deterministic_fixups.enabled = true`)
 
@@ -373,9 +361,6 @@ func TestVectorIndexMergingDuringBackfillWithPrefix(t *testing.T) {
 	defer srv.Stopper().Stop(ctx)
 	sqlDB := sqlutils.MakeSQLRunner(db)
 
-	// Enable vector indexes.
-	sqlDB.Exec(t, `SET CLUSTER SETTING feature.vector_index.enabled = true`)
-
 	// Enable deterministic vector index fixups for consistent testing.
 	sqlDB.Exec(t, `SET CLUSTER SETTING sql.vecindex.deterministic_fixups.enabled = true`)
 

pkg/sql/catalog/tabledesc/index_test.go

@@ -51,9 +51,6 @@ func TestIndexInterface(t *testing.T) {
 	}
 	runner := sqlutils.MakeSQLRunner(conn)
 
-	// Enable vector indexes.
-	runner.Exec(t, `SET CLUSTER SETTING feature.vector_index.enabled = true`)
-
 	runner.Exec(t, `
 		CREATE TABLE d.t (
 			c1 INT,

pkg/sql/logictest/logic.go

@@ -1881,14 +1881,6 @@ func (t *logicTest) newCluster(
 			}
 		}
 
-		// Enable vector indexes by default for tests.
-		// TODO(andyk): Remove this once vector indexes are enabled by default.
-		if _, err := conn.Exec(
-			"SET CLUSTER SETTING feature.vector_index.enabled = true",
-		); err != nil {
-			t.Fatal(err)
-		}
-
 		// Ensure that vector index background operations are deterministic, so
 		// that tests don't flake.
 		if _, err := conn.Exec(

pkg/sql/logictest/testdata/logic_test/event_log

@@ -492,7 +492,6 @@ ORDER BY "timestamp", info
 ----
 1  {"ApplicationName": "$ internal-optInToDiagnosticsStatReporting", "DefaultValue": "true", "EventType": "set_cluster_setting", "SettingName": "diagnostics.reporting.enabled", "Statement": "SET CLUSTER SETTING \"diagnostics.reporting.enabled\" = true", "Tag": "SET CLUSTER SETTING", "User": "node", "Value": "true"}
 1  {"DefaultValue": "-10s", "EventType": "set_cluster_setting", "SettingName": "sql.crdb_internal.table_row_statistics.as_of_time", "Statement": "SET CLUSTER SETTING \"sql.crdb_internal.table_row_statistics.as_of_time\" = e'-1\\u00B5s'", "Tag": "SET CLUSTER SETTING", "User": "root", "Value": "-00:00:00.000001"}
-1  {"DefaultValue": "false", "EventType": "set_cluster_setting", "SettingName": "feature.vector_index.enabled", "Statement": "SET CLUSTER SETTING \"feature.vector_index.enabled\" = true", "Tag": "SET CLUSTER SETTING", "User": "root", "Value": "true"}
 1  {"DefaultValue": "false", "EventType": "set_cluster_setting", "SettingName": "sql.vecindex.deterministic_fixups.enabled", "Statement": "SET CLUSTER SETTING \"sql.vecindex.deterministic_fixups.enabled\" = true", "Tag": "SET CLUSTER SETTING", "User": "root", "Value": "true"}
 1  {"DefaultValue": "true", "EventType": "set_cluster_setting", "SettingName": "kv.allocator.load_based_lease_rebalancing.enabled", "Statement": "SET CLUSTER SETTING \"kv.allocator.load_based_lease_rebalancing.enabled\" = false", "Tag": "SET CLUSTER SETTING", "User": "root", "Value": "false"}
 1  {"DefaultValue": "true", "EventType": "set_cluster_setting", "SettingName": "kv.allocator.load_based_lease_rebalancing.enabled", "Statement": "SET CLUSTER SETTING \"kv.allocator.load_based_lease_rebalancing.enabled\" = DEFAULT", "Tag": "SET CLUSTER SETTING", "User": "root", "Value": "DEFAULT"}
@@ -513,7 +512,6 @@ ORDER BY "timestamp", info
 ----
 1  {"ApplicationName": "$ internal-optInToDiagnosticsStatReporting", "DefaultValue": "true", "EventType": "set_cluster_setting", "SettingName": "diagnostics.reporting.enabled", "Statement": "SET CLUSTER SETTING \"diagnostics.reporting.enabled\" = true", "Tag": "SET CLUSTER SETTING", "User": "node", "Value": "true"}
 1  {"DefaultValue": "-10s", "EventType": "set_cluster_setting", "SettingName": "sql.crdb_internal.table_row_statistics.as_of_time", "Statement": "SET CLUSTER SETTING \"sql.crdb_internal.table_row_statistics.as_of_time\" = e'-1\\u00B5s'", "Tag": "SET CLUSTER SETTING", "User": "root", "Value": "-00:00:00.000001"}
-1  {"DefaultValue": "false", "EventType": "set_cluster_setting", "SettingName": "feature.vector_index.enabled", "Statement": "SET CLUSTER SETTING \"feature.vector_index.enabled\" = true", "Tag": "SET CLUSTER SETTING", "User": "root", "Value": "true"}
 1  {"DefaultValue": "false", "EventType": "set_cluster_setting", "SettingName": "sql.vecindex.deterministic_fixups.enabled", "Statement": "SET CLUSTER SETTING \"sql.vecindex.deterministic_fixups.enabled\" = true", "Tag": "SET CLUSTER SETTING", "User": "root", "Value": "true"}
 1  {"EventType": "set_cluster_setting", "PlaceholderValues": ["'some string'"], "SettingName": "cluster.label", "Statement": "SET CLUSTER SETTING \"cluster.label\" = $1", "Tag": "SET CLUSTER SETTING", "User": "root", "Value": "'some string'"}
 

pkg/sql/logictest/testdata/logic_test/system

@@ -314,7 +314,6 @@ ORDER BY name
 ----
 cluster.secret
 diagnostics.reporting.enabled
-feature.vector_index.enabled
 sql.crdb_internal.table_row_statistics.as_of_time
 sql.vecindex.deterministic_fixups.enabled
 version
@@ -332,7 +331,6 @@ ORDER BY name
 ----
 cluster.secret
 diagnostics.reporting.enabled
-feature.vector_index.enabled
 sql.crdb_internal.table_row_statistics.as_of_time
 sql.vecindex.deterministic_fixups.enabled
 version
@@ -355,7 +353,6 @@ AND name NOT IN ('version', 'cluster.secret', 'kv.range_merge.queue_enabled')
 ORDER BY name
 ----
 diagnostics.reporting.enabled                      true
-feature.vector_index.enabled                       true
 somesetting                                        somevalue
 sql.crdb_internal.table_row_statistics.as_of_time  -1µs
 sql.vecindex.deterministic_fixups.enabled          true
@@ -373,7 +370,6 @@ AND name NOT IN ('version', 'cluster.secret')
 ORDER BY name
 ----
 diagnostics.reporting.enabled                      true
-feature.vector_index.enabled                       true
 somesetting                                        somevalue
 sql.crdb_internal.table_row_statistics.as_of_time  -1µs
 sql.vecindex.deterministic_fixups.enabled          true