Skip to content

Commit 5f9e82f

Browse files
committed
roachtest: deflake cdc/ledger
This patch deflakes `cdc/ledger` by increasing the target steady latency from 1 minute to 3 minutes. It also eliminates a weird quirk where the latency verifier expects the latency to be less than half of the target latency before it'll be considered steady, which led to weird logs and added unnecessary complexity. Release note: None
1 parent 9e0395f commit 5f9e82f

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

pkg/cmd/roachtest/tests/cdc.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2545,7 +2545,7 @@ CONFIGURE ZONE USING
25452545
})
25462546
ct.runFeedLatencyVerifier(feed, latencyTargets{
25472547
initialScanLatency: 10 * time.Minute,
2548-
steadyLatency: time.Minute,
2548+
steadyLatency: 3 * time.Minute,
25492549
})
25502550
ct.waitForWorkload()
25512551
},

pkg/cmd/roachtest/tests/latency_verifier.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ func (lv *latencyVerifier) noteHighwater(highwaterTime time.Time) {
114114
return
115115
}
116116

117-
if lv.targetSteadyLatency == 0 || latency < lv.targetSteadyLatency/2 {
117+
if lv.targetSteadyLatency == 0 || latency < lv.targetSteadyLatency {
118118
lv.latencyBecameSteady = true
119119
}
120120
if !lv.latencyBecameSteady {

0 commit comments

Comments
 (0)