Skip to content

Commit 5f75532

Browse files
authored
Merge pull request #156013 from arulajmani/blathers/backport-release-25.4-155892
release-25.4: kv: deflake TestClosedTimestampFrozenAfterSubsumption
2 parents b4669b9 + a1b4f8d commit 5f75532

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

pkg/kv/kvserver/closed_timestamp_test.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -730,11 +730,16 @@ func TestClosedTimestampFrozenAfterSubsumption(t *testing.T) {
730730
// Set up the closed timestamp timing such that, when we block a merge and
731731
// transfer the RHS lease, the closed timestamp advances over the LHS
732732
// lease but not over the RHS lease.
733+
//
734+
// NB: We want to ensure that the closed timestamp on the LHS is less than
735+
// the lease start time for the RHS after the lease transfer. To ensure
736+
// this holds and doesn't flake, we increase the target duration to 10
737+
// seconds.
733738
tc, _, _ := setupClusterForClosedTSTesting(ctx, t, 5*time.Second, 100*time.Millisecond, clusterArgs, "cttest", "kv")
734739
defer tc.Stopper().Stop(ctx)
735740
sqlDB := sqlutils.MakeSQLRunner(tc.ServerConn(0))
736741
sqlDB.ExecMultiple(t, strings.Split(`
737-
SET CLUSTER SETTING kv.closed_timestamp.target_duration = '5s';
742+
SET CLUSTER SETTING kv.closed_timestamp.target_duration = '10s';
738743
SET CLUSTER SETTING kv.closed_timestamp.side_transport_interval = '100ms';
739744
SET CLUSTER SETTING kv.rangefeed.closed_timestamp_refresh_interval = '100ms';
740745
SET CLUSTER SETTING kv.closed_timestamp.follower_reads.enabled = true;

0 commit comments

Comments
 (0)