mmaprototype: refactor computeMeansForStoreSet

Previously, we updated computeMeansForStoreSet to take meansLoad and
[]roachpb.StoreID directly instead of a meansForStoreSet struct. This commit
updates the call sites that only require meansLoad to use it directly, removing
unnecessary use of meansForStoreSet.

Author: wenyihu6

pkg/kv/kvserver/allocator/mmaprototype/allocator_state.go

@@ -473,10 +473,9 @@ func (a *allocatorState) rebalanceStores(
 				if len(candsPL) <= 1 {
 					continue // leaseholder is the only candidate
 				}
-				var means meansForStoreSet
+				var means meansLoad
 				clear(scratchNodes)
-				means.stores = candsPL
-				computeMeansForStoreSet(a.cs, &means.meansLoad, means.stores, scratchNodes)
+				computeMeansForStoreSet(a.cs, &means, candsPL, scratchNodes)
 				sls := a.cs.computeLoadSummary(ctx, store.StoreID, &means.storeLoad, &means.nodeLoad)
 				log.KvDistribution.VInfof(ctx, 2, "considering lease-transfer r%v from s%v: candidates are %v", rangeID, store.StoreID, candsPL)
 				if sls.dimSummary[CPURate] < overloadSlow {
@@ -948,7 +947,7 @@ type candidateInfo struct {
 
 type candidateSet struct {
 	candidates []candidateInfo
-	means      *meansForStoreSet
+	means      *meansLoad
 }
 
 type ignoreLevel uint8
@@ -1390,7 +1389,7 @@ func (a *allocatorState) computeCandidatesForRange(
 			storeLoadSummary: csls,
 		})
 	}
-	cset.means = means
+	cset.means = &means.meansLoad
 	return cset, sheddingSLS
 }
 

pkg/kv/kvserver/allocator/mmaprototype/cluster_state.go

@@ -1949,7 +1949,7 @@ func (cs *clusterState) canShedAndAddLoad(
 	srcSS *storeState,
 	targetSS *storeState,
 	delta LoadVector,
-	means *meansForStoreSet,
+	means *meansLoad,
 	onlyConsiderTargetCPUSummary bool,
 	overloadedDim LoadDimension,
 ) (canAddLoad bool) {