rangefeed: cleanup test output

A couple more cases of missing log.Scopes and some uses of fmt.Printf
rather than t.Log.

Epic: none
Release note: None

Author: stevendanna

pkg/kv/kvserver/rangefeed/catchup_scan_test.go

@@ -278,6 +278,8 @@ func TestCatchupScanInlineError(t *testing.T) {
 
 func TestCatchupScanSeesOldIntent(t *testing.T) {
 	defer leaktest.AfterTest(t)()
+	defer log.Scope(t).Close(t)
+
 	// Regression test for [#85886]. When with-diff is specified, the iterator may
 	// be positioned on an intent that is outside the time bounds. When we read
 	// the intent and want to load the version, we must make sure to ignore time

pkg/kv/kvserver/rangefeed/processor_test.go

@@ -1200,7 +1200,7 @@ func TestBudgetReleaseOnProcessorStop(t *testing.T) {
 		// after flushing the queue, but couldn't determine when main processor loop
 		// is actually closed.
 		testutils.SucceedsSoon(t, func() error {
-			fmt.Printf("Budget now: %d bytes remained, %d events processed\n",
+			t.Logf("budget: %d bytes remained, %d events processed",
 				m.AllocBytes(), rStream.Consumed())
 			if m.AllocBytes() != 0 {
 				return errors.Errorf(
@@ -1367,7 +1367,7 @@ func requireBudgetDrainedSoon(t *testing.T, b *FeedBudget, stream *consumer) {
 		b.mu.Lock()
 		used := b.mu.memBudget.Used()
 		b.mu.Unlock()
-		fmt.Printf("Budget used: %d bytes, %d events processed\n",
+		t.Logf("budget used: %d bytes, %d events processed",
 			used, stream.Consumed())
 		if used != 0 {
 			return errors.Errorf(

pkg/kv/kvserver/rangefeed/task_test.go

@@ -18,6 +18,7 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/storage/enginepb"
 	"github.com/cockroachdb/cockroach/pkg/util/hlc"
 	"github.com/cockroachdb/cockroach/pkg/util/leaktest"
+	"github.com/cockroachdb/cockroach/pkg/util/log"
 	"github.com/cockroachdb/cockroach/pkg/util/protoutil"
 	"github.com/cockroachdb/cockroach/pkg/util/uuid"
 	"github.com/stretchr/testify/require"
@@ -243,6 +244,7 @@ func (s *testIterator) RangeKeyChanged() bool {
 
 func TestInitResolvedTSScan(t *testing.T) {
 	defer leaktest.AfterTest(t)()
+	defer log.Scope(t).Close(t)
 	ctx := context.Background()
 
 	startKey := roachpb.RKey("d")