Merge #155233

155233: dev-inf: Fix stage chaining in Claude Code GH action r=rickystewart a=ajstorm

The claude-code-action doesn't export a 'result' output variable.
Added extraction steps between each stage to:
1. Read the execution_file output from each stage
2. Parse the JSON to extract the result field
3. Set it as an output for the next stage's conditional

This fixes the issue where Stage 2 and Stage 3 were being skipped
even when bugs were detected in earlier stages.

Epic: none
Release note: none

Co-authored-by: Adam Storm <storm@cockroachlabs.com>

Author: craig[bot]

.github/workflows/pr-analyzer-threestage.yml

@@ -62,9 +62,21 @@ jobs:
             - `STAGE1_RESULT - POTENTIAL_BUG_DETECTED` or
             - `STAGE1_RESULT - NO_BUG_FOUND`
 
+      - name: Extract Stage 1 Result
+        id: stage1_result
+        if: steps.stage1.conclusion == 'success'
+        run: |
+          RESULT=$(jq -r 'select(.type == "result") | .result' "${{ steps.stage1.outputs.execution_file }}")
+          {
+            echo 'result<<EOF'
+            echo "$RESULT"
+            echo 'EOF'
+          } >> "$GITHUB_OUTPUT"
+          echo "Stage 1 result extracted (${#RESULT} characters)"
+
       - name: Stage 2 - Database Expert Review
         id: stage2
-        if: contains(steps.stage1.outputs.result, 'STAGE1_RESULT - POTENTIAL_BUG_DETECTED')
+        if: contains(steps.stage1_result.outputs.result, 'STAGE1_RESULT - POTENTIAL_BUG_DETECTED')
         uses: cockroachdb/claude-code-action@v1
         env:
           ANTHROPIC_VERTEX_PROJECT_ID: vertex-model-runners
@@ -83,7 +95,7 @@ jobs:
             found potential issues. Your job is to confirm or reject those findings.
 
             **Stage 1 Results**:
-            ${{ steps.stage1.outputs.result }}
+            ${{ steps.stage1_result.outputs.result }}
 
             Review the Stage 1 findings and perform your own analysis. Do not identify
             new bugs unless they're glaringly obvious.
@@ -100,9 +112,21 @@ jobs:
             - `STAGE2_RESULT - POTENTIAL_BUG_DETECTED [detailed description of confirmed bugs]` or
             - `STAGE2_RESULT - NO_BUG_FOUND`
 
+      - name: Extract Stage 2 Result
+        id: stage2_result
+        if: steps.stage2.conclusion == 'success'
+        run: |
+          RESULT=$(jq -r 'select(.type == "result") | .result' "${{ steps.stage2.outputs.execution_file }}")
+          {
+            echo 'result<<EOF'
+            echo "$RESULT"
+            echo 'EOF'
+          } >> "$GITHUB_OUTPUT"
+          echo "Stage 2 result extracted (${#RESULT} characters)"
+
       - name: Stage 3 - Principal Engineer Final Review
         id: stage3
-        if: contains(steps.stage2.outputs.result, 'STAGE2_RESULT - POTENTIAL_BUG_DETECTED')
+        if: contains(steps.stage2_result.outputs.result, 'STAGE2_RESULT - POTENTIAL_BUG_DETECTED')
         uses: cockroachdb/claude-code-action@v1
         env:
           ANTHROPIC_VERTEX_PROJECT_ID: vertex-model-runners
@@ -121,10 +145,10 @@ jobs:
             Two previous stages have found potential issues that need final validation.
 
             **Stage 1 Results**:
-            ${{ steps.stage1.outputs.result }}
+            ${{ steps.stage1_result.outputs.result }}
 
             **Stage 2 Results**:
-            ${{ steps.stage2.outputs.result }}
+            ${{ steps.stage2_result.outputs.result }}
 
             This is the final gate before flagging this PR as having critical bugs.
             Only confirm bugs that could cause:
@@ -153,6 +177,18 @@ jobs:
             - `STAGE3_RESULT: POTENTIAL_BUG_CONFIRMED` or
             - `STAGE3_RESULT: NO_BUG_FOUND`
 
+      - name: Extract Stage 3 Result
+        id: stage3_result
+        if: steps.stage3.conclusion == 'success'
+        run: |
+          RESULT=$(jq -r 'select(.type == "result") | .result' "${{ steps.stage3.outputs.execution_file }}")
+          {
+            echo 'result<<EOF'
+            echo "$RESULT"
+            echo 'EOF'
+          } >> "$GITHUB_OUTPUT"
+          echo "Stage 3 result extracted (${#RESULT} characters)"
+
       - name: Final Analysis Report
         if: always()
         uses: cockroachdb/claude-code-action@v1
@@ -173,9 +209,9 @@ jobs:
 
             Generate a final summary report based on the completed analysis stages:
 
-            **Stage 1 Result**: ${{ steps.stage1.outputs.result || 'Not completed' }}
-            **Stage 2 Result**: ${{ steps.stage2.outputs.result || 'Skipped - Stage 1 found no bugs' }}
-            **Stage 3 Result**: ${{ steps.stage3.outputs.result || 'Skipped - Stage 2 did not confirm bugs' }}
+            **Stage 1 Result**: ${{ steps.stage1_result.outputs.result || 'Not completed' }}
+            **Stage 2 Result**: ${{ steps.stage2_result.outputs.result || 'Skipped - Stage 1 found no bugs' }}
+            **Stage 3 Result**: ${{ steps.stage3_result.outputs.result || 'Skipped - Stage 2 did not confirm bugs' }}
 
             **Analysis Process**:
             - Stage 1 (Initial Screening): ${{ steps.stage1.conclusion }}
@@ -187,4 +223,16 @@ jobs:
             2. The final determination (critical bug found or no critical bugs)
             3. If bugs were found, what actions are recommended
 
-            **If all three stages detected bugs**, this indicates a potential issue that warrants investigation.
+            **If all three stages detected bugs**, this indicates a potential issue that warrants investigation.
+
+      - name: Comment on PR if bugs confirmed
+        if: contains(steps.stage3_result.outputs.result, 'STAGE3_RESULT: POTENTIAL_BUG_CONFIRMED')
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          gh pr comment ${{ github.event.pull_request.number }} --body "## Potential Bug(s) Detected
+
+          The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.
+
+          **Next Steps:**
+          Please review the detailed findings in the [workflow run](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})."