Skip to content

Commit 1674122

Browse files
committed
roachtest: route more schema change workload flakes to foundations
It appears that errors prefaced with "UNEXPECTED COMMIT ERRORS" also signal a workload flake. Informs #155141 Release note: none
1 parent 738c039 commit 1674122

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

pkg/cmd/roachtest/tests/backup_restore_roundtrip.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,11 @@ func handleSchemaChangeWorkloadError(err error) error {
4949
// If the UNEXPECTED ERROR detail appears, the workload likely flaked.
5050
// Otherwise, the workload could have failed due to other reasons like a node
5151
// crash.
52-
if err != nil && strings.Contains(errors.FlattenDetails(err), "UNEXPECTED ERROR") {
53-
return registry.ErrorWithOwner(registry.OwnerSQLFoundations, errors.Wrapf(err, "schema change workload failed"))
52+
if err != nil {
53+
flattenedErr := errors.FlattenDetails(err)
54+
if strings.Contains(flattenedErr, "UNEXPECTED ERROR") || strings.Contains(flattenedErr, "UNEXPECTED COMMIT ERROR") {
55+
return registry.ErrorWithOwner(registry.OwnerSQLFoundations, errors.Wrapf(err, "schema change workload failed"))
56+
}
5457
}
5558
return err
5659
}

0 commit comments

Comments
 (0)