fix: rework outdated tests

Author: BuonOmo

test/cases/defaults_test.rb

@@ -15,10 +15,10 @@ class DefaultExpressionTest < ActiveRecord::TestCase
       output = dump_table_schema("defaults")
 
       assert_match %r/t\.date\s+"modified_date",\s+default: -> { \"current_date\(\)\" }/, output
-      assert_match %r/t\.datetime\s+"modified_time",\s+precision: nil,\s+default: -> { "current_timestamp\(\)" }/, output
+      assert_match %r/t\.datetime\s+"modified_time",\s+default: -> { "current_timestamp\(\)" }/, output
 
       assert_match %r/t\.date\s+"modified_date_function",\s+default: -> { "now\(\)" }/, output
-      assert_match %r/t\.datetime\s+"modified_time_function",\s+precision: nil,\s+default: -> { "now\(\)" }/, output
+      assert_match %r/t\.datetime\s+"modified_time_function",\s+default: -> { "now\(\)" }/, output
     end
   end
 

test/cases/migration/change_schema_test.rb

@@ -127,40 +127,6 @@ def test_create_table_with_limits
           assert_equal "bigint", eight.sql_type
         end
 
-        def test_add_column_with_postgresql_datetime_type
-          connection.create_table :testings do |t|
-            t.column :foo, :datetime
-          end
-
-          column = connection.columns(:testings).find { |c| c.name == "foo" }
-
-          assert_equal :datetime, column.type
-
-          if current_adapter?(:PostgreSQLAdapter)
-            assert_equal "timestamp without time zone", column.sql_type
-          elsif current_adapter?(:Mysql2Adapter)
-            sql_type = supports_datetime_with_precision? ? "datetime(6)" : "datetime"
-            assert_equal sql_type, column.sql_type
-          else
-            assert_equal connection.type_to_sql("datetime(6)"), column.sql_type
-          end
-        end
-
-        if current_adapter?(:PostgreSQLAdapter)
-          def test_add_column_with_datetime_in_timestamptz_mode
-            with_cockroachdb_datetime_type(:timestamptz) do
-              connection.create_table :testings do |t|
-                t.column :foo, :datetime
-              end
-
-              column = connection.columns(:testings).find { |c| c.name == "foo" }
-
-              assert_equal :datetime, column.type
-              assert_equal "timestamp with time zone", column.sql_type
-            end
-          end
-        end
-
         private
           def testing_table_with_only_foo_attribute
             connection.create_table :testings, id: false do |t|

test/excludes/ActiveRecord/Migration/ChangeSchemaTest.rb

@@ -5,5 +5,3 @@
 exclude :test_drop_table_if_exists, "It's not possible to check for the result of an operation in the same txn as which the operation is performed"
 exclude :test_change_column_null, "It's not possible to check for the result of an operation in the same txn as which the operation is performed"
 exclude :test_keeping_default_and_notnull_constraints_on_change, "It's not possible to check for the result of an operation in the same txn as which the operation is performed"
-exclude :test_add_column_with_postgresql_datetime_type, "Re-implement our own version"
-exclude :test_add_column_with_datetime_in_timestamptz_mode, "We need to use an Adapter specific method in this test"