Skip to content

Commit d97084f

Browse files
committed
refactor insert() method
1 parent 35a323a commit d97084f

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

simple_query_builder/querybuilder.py

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ def _prepare_fieldlist(self, fields: Union[str, tuple, list] = ()) -> str:
365365
if isinstance(fields, str):
366366
result = self._prepare_field(fields)
367367
elif isinstance(fields, tuple) or isinstance(fields, list):
368-
fields = [f"{self._prepare_field(field)}" for field in fields]
368+
fields = [self._prepare_field(field) for field in fields]
369369
result = ', '.join(fields)
370370

371371
return result
@@ -393,8 +393,7 @@ def group_by(self, field: Union[str, tuple, list] = ()):
393393
self.set_error(f"Empty field in {inspect.stack()[0][3]} method")
394394
return self
395395

396-
field = self._prepare_fieldlist(field)
397-
self._sql += f" GROUP BY {field}"
396+
self._sql += f" GROUP BY {self._prepare_fieldlist(field)}"
398397

399398
return self
400399

@@ -421,10 +420,8 @@ def insert(self, table: Union[str, dict], fields: Union[list, dict]):
421420
self.set_error(f"Empty table or fields in {inspect.stack()[0][3]} method")
422421
return self
423422

424-
if isinstance(table, dict):
425-
table = f"`{self._prepare_aliases(table)}`"
426-
elif isinstance(table, str):
427-
table = f"`{table}`"
423+
if isinstance(table, dict) or isinstance(table, str):
424+
table = self._prepare_aliases(table)
428425
else:
429426
self.set_error(f"Incorrect type of table in {inspect.stack()[0][3]} method. Table must be String or Dictionary")
430427
return self
@@ -433,14 +430,14 @@ def insert(self, table: Union[str, dict], fields: Union[list, dict]):
433430

434431
if isinstance(fields, dict):
435432
values = ("?," * len(fields)).rstrip(',')
436-
self._sql = f"INSERT INTO {table} (`" + '`, `'.join(list(fields.keys())) + f"`) VALUES ({values})"
433+
self._sql = f"INSERT INTO {table} (" + self._prepare_fieldlist(list(fields.keys())) + f") VALUES ({values})"
437434
self._params = tuple(fields.values())
438435
elif isinstance(fields, list):
439436
names = fields.pop(0)
440437
value = ("?," * len(names)).rstrip(',')
441438
v = f"({value}),"
442439
values = (v * len(fields)).rstrip(',')
443-
self._sql = f"INSERT INTO {table} (`" + '`, `'.join(names) + f"`) VALUES {values}"
440+
self._sql = f"INSERT INTO {table} (" + self._prepare_fieldlist(names) + f") VALUES {values}"
444441
params = []
445442
for item in fields:
446443
if isinstance(item, list):

0 commit comments

Comments
 (0)