Skip to content

Commit d7fd1e1

Browse files
committed
refactor join() method
1 parent 779af60 commit d7fd1e1

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

simple_query_builder/querybuilder.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -485,18 +485,16 @@ def join(self, table: Union[str, dict] = '', on: Union[str, tuple, list] = (), j
485485
self.set_error(f"Empty table in {inspect.stack()[0][3]} method")
486486
return self
487487

488-
if isinstance(table, dict):
488+
if isinstance(table, dict) or isinstance(table, str):
489489
self._sql += f" {join_type} JOIN {self._prepare_aliases(table)}"
490-
elif isinstance(table, str):
491-
self._sql += f" {join_type} JOIN `{table}`"
492490
else:
493491
self.set_error(f"Incorrect type of table in {inspect.stack()[0][3]} method. Table must be String or Dictionary")
494492
return self
495493

496494
if on:
497495
if isinstance(on, tuple) or isinstance(on, list):
498-
field1 = f"`{on[0].replace('.', '`.`')}`"
499-
field2 = f"`{on[1].replace('.', '`.`')}`"
496+
field1 = self._prepare_field(on[0])
497+
field2 = self._prepare_field(on[1])
500498
self._sql += f" ON {field1} = {field2}"
501499
elif isinstance(on, str):
502500
self._sql += f" ON {on}"

0 commit comments

Comments
 (0)