Skip to content

Commit 0dd5345

Browse files
committed
refactor group_by() method
1 parent fd2e63a commit 0dd5345

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

simple_query_builder/querybuilder.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -395,13 +395,14 @@ def order_by(self, field: Union[str, tuple, list] = (), sort: str = ''):
395395

396396
return self
397397

398-
def group_by(self, field: str = ''):
399-
if field == '':
398+
def group_by(self, field: Union[str, tuple, list] = ()):
399+
if field == '' or field == () or field == []:
400400
self.set_error(f"Empty field in {inspect.stack()[0][3]} method")
401401
return self
402402

403-
field = field.replace('.', '`.`')
404-
self._sql += f" GROUP BY `{field}`"
403+
field = self._prepare_fieldlist(field)
404+
self._sql += f" GROUP BY {field}"
405+
405406
return self
406407

407408
def delete(self, table: Union[str, dict]):

0 commit comments

Comments
 (0)