Skip legacy HHVM test failure regarding secure TLS connections

clue · clue · commit d5ceb3f670b2 · 2021-04-22T09:00:31.000+02:00
diff --git a/tests/FunctionalTest.php b/tests/FunctionalTest.php
@@ -61,8 +61,8 @@ public function testPlainGoogleDoesNotAcceptConnectMethod()
 
     public function testSecureGoogleDoesNotAcceptConnectMethod()
     {
-        if (!function_exists('stream_socket_enable_crypto')) {
-            $this->markTestSkipped('TLS not supported on really old platforms (HHVM < 3.8)');
+        if (defined('HHVM_VERSION')) {
+            $this->markTestSkipped('TLS not supported on legacy HHVM');
         }
 
         $secure = new SecureConnector($this->dnsConnector, $this->loop);

Original file line number	Diff line number	Diff line change
`@@ -61,8 +61,8 @@ public function testPlainGoogleDoesNotAcceptConnectMethod()`
`61`	`61`
`62`	`62`	`public function testSecureGoogleDoesNotAcceptConnectMethod()`
`63`	`63`	`{`
`64`		`- if (!function_exists('stream_socket_enable_crypto')) {`
`65`		`- $this->markTestSkipped('TLS not supported on really old platforms (HHVM < 3.8)');`
	`64`	`+ if (defined('HHVM_VERSION')) {`
	`65`	`+ $this->markTestSkipped('TLS not supported on legacy HHVM');`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`$secure = new SecureConnector($this->dnsConnector, $this->loop);`